Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756391Ab1FFDqW (ORCPT ); Sun, 5 Jun 2011 23:46:22 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:54027 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755800Ab1FFDqU (ORCPT ); Sun, 5 Jun 2011 23:46:20 -0400 Message-ID: <4DEC4D67.6010506@oracle.com> Date: Sun, 05 Jun 2011 20:45:43 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Grant Likely CC: Mark Brown , Stephen Rothwell , alsa-devel@alsa-project.org, Dmitry Artamonow , x86@kernel.org, LKML , linux-next@vger.kernel.org, Harald Welte Subject: Re: [PATCH] gpio: add GPIOF_ values regardless on kconfig settings References: <20110523155343.2e68c265.randy.dunlap@oracle.com> <20110524000837.GA30515@opensource.wolfsonmicro.com> <4DDB082F.3010107@oracle.com> <20110524014959.GA27710@opensource.wolfsonmicro.com> <4DDB3AFF.9030006@oracle.com> <20110524075248.GB19734@sirena.org.uk> <20110527074552.GA907@ponder.secretlab.ca> <4DDFE391.2030507@oracle.com> <20110527201201.GA6645@ponder.secretlab.ca> <20110603171837.GA9918@opensource.wolfsonmicro.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4DEC4D77.0066:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 34 On 06/03/11 10:42, Grant Likely wrote: > On Fri, Jun 3, 2011 at 11:18 AM, Mark Brown > wrote: >> On Fri, Jun 03, 2011 at 11:04:52AM -0600, Grant Likely wrote: >> >>> I ended up not pushing this one to Linus. Turns out it causes other >>> breakage on other platforms that don't include include/linux/gpio.h. >>> Since I don't have confidence that I'll be able to find all the >>> offenders, I'm dropping it. I recommend making any drivers that are >> >> So, this originally came about because I pushed back on adding random >> dependencies like this for features which are pretty much optional in >> drivers - their use of GPIOs is totally optional and the dependencies >> are just too fragile, leading to noise with all the randconfigs. It >> seems better to get the architectures to keep up with enhancements to >> gpiolib (or convert to it) than to have to worry about this in drivers. > > Fair enough. Randy, if you or someone else can check that all GPIOF_ > users have the required #include , then I'm okay with > this patch. OK, I'll look at that. Do you have any examples of builds that failed with this patch? thanks, -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/