Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756925Ab1FFIL7 (ORCPT ); Mon, 6 Jun 2011 04:11:59 -0400 Received: from mail-vx0-f174.google.com ([209.85.220.174]:54655 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175Ab1FFILy convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2011 04:11:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=s47JDooPTOPdl8CFs080tMNHZD6hRPkmbz3OcYMj06qJ8ek9s9C+Yfj7vXDKZbOXao hlVMgMondgliGqEr/9xjJ1Cr+cdWPuRLWhgIZIyU49+zi6u5sT4gq3e+OHRRwjG5g2k9 cmlwRyybtYD5aFsSZ1n+SR+GPd5XatC8X6cJg= MIME-Version: 1.0 In-Reply-To: <874o43ii1m.fsf@rustcorp.com.au> References: <874o43ii1m.fsf@rustcorp.com.au> Date: Mon, 6 Jun 2011 10:11:53 +0200 Message-ID: Subject: Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit From: richard -rw- weinberger To: Rusty Russell Cc: Christian Dietrich , "Venkatesh Pallipadi (Venki)" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Avi Kivity , Marcelo Tosatti , Kevin Tian , Fengzhe Zhang , John Stultz , Lucas De Marchi , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lguest@lists.ozlabs.org, trivial@kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 35 On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell wrote: > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich wrote: >> Since printk_ratelimit() shouldn't be used anymore (see comment in >> include/linux/printk.h), replace it with printk_ratelimited. > > Acked-by: Rusty Russell (lguest part) > >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c >> index db832fd..23a6eff 100644 >> --- a/arch/x86/lguest/boot.c >> +++ b/arch/x86/lguest/boot.c >> @@ -56,6 +56,7 @@ >> ?#include >> ?#include >> ?#include >> +#include >> ?#include >> ?#include >> ?#include > > Is this new include really needed? ?The printk_ratelimited() definition > is in printk.h... Yes. printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined in ratelimit.h. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/