Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155Ab1FFL3i (ORCPT ); Mon, 6 Jun 2011 07:29:38 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:33020 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754302Ab1FFL3h (ORCPT ); Mon, 6 Jun 2011 07:29:37 -0400 Message-ID: <4DECBA16.7070300@in.ibm.com> Date: Mon, 06 Jun 2011 16:59:26 +0530 From: Suzuki Poulose User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: David Laight CC: Simon Horman , linux ppc dev , Sebastian Andrzej Siewior , kexec@lists.infradead.org, lkml , Vivek Goyal Subject: Re: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 29 On 06/06/11 14:30, David Laight wrote: >>> Changed the add_usable_mem_property() to accept FILE* fp instead of > int fd, >>> as most of the other users of read_memory_region_limits() deals with > FILE*. >>> >>> Signed-off-by: Suzuki K. Poulose >> >> Could you please let me know your thoughts/comments about this patch ? > > Is the change to use 'FILE *' actually progress? > I'd have thought that the randomly aligned read/lseek system calls > that this allows to happen are not desirable for anything that > isn't a true file. I will revert the other users back to 'fd' > > I'd also suggest that the sizeof's should be applied to the > actual type of the variable being read/written, not arbitrarily > 'long' or 'int', and this probably ought to be some fixed size type. I have used 'unsigned long'(for word sized values) or 'unsigned long long' (for double words) just to make sure we get the right values. Is this OK ? Thanks Suzuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/