Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763Ab1FFRll (ORCPT ); Mon, 6 Jun 2011 13:41:41 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:50493 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121Ab1FFRlk (ORCPT ); Mon, 6 Jun 2011 13:41:40 -0400 Date: Mon, 6 Jun 2011 19:41:29 +0200 From: Ingo Molnar To: Andy Lutomirski Cc: x86@kernel.org, pageexec@freemail.hu, Mikael Pettersson , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 2/3] x86-64: Clean up vsyscall emulation and remove fixed-address ret Message-ID: <20110606174129.GA6412@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1173 Lines: 34 * Andy Lutomirski wrote: > Remove the fixed-address ret in the vsyscall emulation stubs. As a > result, int 0xcc no longer works if executed from user address space > (which is OK -- nothing sensible should do that). > > Removing support for int 0xcc in user address space cleans up the > code considerably. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/include/asm/vsyscall.h | 10 ++++- > arch/x86/kernel/vsyscall_64.c | 78 +++++++++++-------------------------- > arch/x86/kernel/vsyscall_emu_64.S | 17 +-------- > 3 files changed, 32 insertions(+), 73 deletions(-) Ok, this makes the whole series a lot more palatable! Can i propagate the rename suggested by hpa into patch #3: CONFIG_COMPAT_VSYSCALL => CONFIG_LEGACY_VSYSCALL ? 'legacy' is probably the best name for this and it thus won't be confused with the 32-bit compat facilities we have. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/