Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756936Ab1FFRqQ (ORCPT ); Mon, 6 Jun 2011 13:46:16 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:50936 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292Ab1FFRqM convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2011 13:46:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=pLa1fyt8S6tCqstHgFj3dL6KhmXOYf/wA6Jo459GQ7KPP1hrWFO3NZAmXQyMjFnmgS /Qh0hEiHwytcB3VyyYdOSkjhYJezjZv6lKshKvFcvvsopF4hbBJS1MIoPeR4j7PyAsFH obzvKsn/soJMjxgF50EAP/n/WwKAdHdEvJZCk= MIME-Version: 1.0 In-Reply-To: <20110606174129.GA6412@elte.hu> References: <20110606174129.GA6412@elte.hu> From: Andrew Lutomirski Date: Mon, 6 Jun 2011 13:45:52 -0400 X-Google-Sender-Auth: wV5oKVQALdtDPXtrrALlRdq6UqQ Message-ID: Subject: Re: [PATCH 2/3] x86-64: Clean up vsyscall emulation and remove fixed-address ret To: Ingo Molnar Cc: x86@kernel.org, pageexec@freemail.hu, Mikael Pettersson , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Linus Torvalds Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 42 On Mon, Jun 6, 2011 at 1:41 PM, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > >> Remove the fixed-address ret in the vsyscall emulation stubs. ?As a >> result, int 0xcc no longer works if executed from user address space >> (which is OK -- nothing sensible should do that). >> >> Removing support for int 0xcc in user address space cleans up the >> code considerably. >> >> Signed-off-by: Andy Lutomirski >> --- >> ?arch/x86/include/asm/vsyscall.h ? | ? 10 ++++- >> ?arch/x86/kernel/vsyscall_64.c ? ? | ? 78 +++++++++++-------------------------- >> ?arch/x86/kernel/vsyscall_emu_64.S | ? 17 +-------- >> ?3 files changed, 32 insertions(+), 73 deletions(-) > > Ok, this makes the whole series a lot more palatable! > > Can i propagate the rename suggested by hpa into patch #3: > > ?CONFIG_COMPAT_VSYSCALL => CONFIG_LEGACY_VSYSCALL Certainly! CONFIG_LEGACY_VTIME might be even better, but I'm fine with any renaming you'd like to do. --Andy > > ? 'legacy' is probably the best name for this and it thus won't be > confused with the 32-bit compat facilities we have. > > Thanks, > > ? ? ? ?Ingo > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/