Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757291Ab1FFSVA (ORCPT ); Mon, 6 Jun 2011 14:21:00 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:45187 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755956Ab1FFSU6 (ORCPT ); Mon, 6 Jun 2011 14:20:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=CpjJ/UkuugAKxorkdWhPLnDmwP/t6JcAnt3dqA83ubU4XhnpBMPi7dfGtNcdfnuN2n weOnCum7EcMYepK6J36eAO9E0uFJbeY3OdQlRkEjhcRzveIWjIOiO25XT9vzUdDLEZIC Xj/r7GR+pi12gmHjatTvEsMoKBI5mT1rH3aYE= Date: Mon, 6 Jun 2011 20:20:54 +0200 From: Frederic Weisbecker To: "Paul E. McKenney" Cc: Milton Miller , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , LKML Subject: Re: [1/4] rcu: Detect uses of rcu read side in extended quiescent states Message-ID: <20110606182052.GC7862@somewhere> References: <1307329858-14999-3-git-send-email-fweisbec@gmail.com> <20110606181021.GL3066@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110606181021.GL3066@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1890 Lines: 42 On Mon, Jun 06, 2011 at 11:10:21AM -0700, Paul E. McKenney wrote: > On Sun, Jun 05, 2011 at 10:44:33PM -0500, Milton Miller wrote: > > On Mon, 06 Jun 2011 about 03:10:55 -0000, Frederic Weisbecker wrote: > > > @@ -3994,8 +3995,13 @@ void lockdep_rcu_dereference(const char *file, const int line) > > > printk("\n===================================================\n"); > > > printk( "[ INFO: suspicious rcu_dereference_check() usage. ]\n"); > > > printk( "---------------------------------------------------\n"); > > > - printk("%s:%d invoked rcu_dereference_check() without protection!\n", > > > - file, line); > > > + printk("%s:%d invoked rcu_dereference_check() ", file, line); > > > + > > > + if (type == RCU_WARN_UNPROTECTED) > > > + printk("without protection!\n"); > > > + else if (type == RCU_WARN_EXT_QS) > > > + printk("while in RCU extended quiescent state!\n"); > > > + > > > printk("\nother info that might help us debug this:\n\n"); > > > printk("\nrcu_scheduler_active = %d, debug_locks = %d\n", rcu_scheduler_active, debug_locks); > > > lockdep_print_held_locks(curr); > > > > Can we keep the above in one printk? That way the printing is > > guaranteed to come out on one line. Probably the easiest way would > > be add char *why = "" then assign a string based on the current > > conditions. Do all of that before the first printk which gets the > > a %s added. > > I have the following queued the -rcu tree which does add the string. > > Frederic, would it be possible to base on this patch? > > Thanx, Paul No problem. Will respin soon. What's the branch in your tree? rcu/next ? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/