Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755860Ab1FFVWO (ORCPT ); Mon, 6 Jun 2011 17:22:14 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:38704 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755595Ab1FFVWM (ORCPT ); Mon, 6 Jun 2011 17:22:12 -0400 Date: Mon, 6 Jun 2011 22:22:09 +0100 From: Al Viro To: H Hartley Sweeten Cc: Linux Kernel Subject: Re: [PATCH] seq_file.h: introduce DECLARE_SEQ_FOPS_{RO,RW} Message-ID: <20110606212209.GM11521@ZenIV.linux.org.uk> References: <201106061319.45855.hartleys@visionengravers.com> <20110606210755.GL11521@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 25 On Mon, Jun 06, 2011 at 04:19:15PM -0500, H Hartley Sweeten wrote: > On Monday, June 06, 2011 2:08 PM, Al Viro wrote: > > On Mon, Jun 06, 2011 at 01:19:45PM -0700, H Hartley Sweeten wrote: > >> Many of the procfs and debugfs attribute file_operations in the kernel are > >> missing the .owner information. Introduce some macro's to fill in the .owner > >> field as well as the common methods for virtual file file_operations. This > >> simplifies creating the attributes and makes sure all the fields are properly > >> initialized. > >> > >> Signed-off-by: H Hartley Sweeten > > > > Nacked-by: Al Viro > > Nacked-because: too ugly > > > > Don't play that kind of games with preprocessor. > > Just an FYI, the exact same thing is being done with DEFINE_SIMPLE_ATTRIBUTE > in fs.h: Yes, and DEFINE_SIMPLE_ATTRIBUTE is sick and ugly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/