Subject: Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.
From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@suse.de>
Cc: anish <anish198519851985@gmail.com>, devel@driverdev.osuosl.org,
        arnd@arndb.de, lucas.demarchi@profusion.mobi,
        linux-kernel@vger.kernel.org, jic23@cam.ac.uk,
        manuel.stahl@iis.fraunhofer.de
In-Reply-To: <20110606222118.GA29883@suse.de>
References: <1307387257.4327.12.camel@anish-desktop>
	 <20110606215549.GA7543@suse.de> <1307398257.4994.30.camel@Joe-Laptop>
	 <20110606222118.GA29883@suse.de>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 06 Jun 2011 15:28:29 -0700
Message-ID: <1307399309.4994.34.camel@Joe-Laptop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 29

On Mon, 2011-06-06 at 15:21 -0700, Greg KH wrote:
> On Mon, Jun 06, 2011 at 03:10:57PM -0700, Joe Perches wrote:
> > On Mon, 2011-06-06 at 14:55 -0700, Greg KH wrote:
> > > On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote:
> > > > From: anish kumar <anish198519851985@gmail.com>
> > > > Replace kmalloc with local variables as it was un-necessary and
> > > > also removed the redudant code after this change.
> > > SPI data, like USB data, has to come from kmalloced data, not from the
> > > stack, or bad things can, and will, happen.
> > Perhaps just add a comment like:
> > +       u8 *tx = kmalloc(2, GFP_KERNEL);	/* can't be on stack */
> You really want to do to that for _EVERY_ SPI and USB driver?  I don't
> think so.

Nope, only the ones that look especially odd because 
	kmalloc(sizeof(struct foo), ...)
or
	kmalloc(sizeof("type), ...)
is not used.

It might be better to just declare a 2 byte struct.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/