Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756969Ab1FGCXt (ORCPT ); Mon, 6 Jun 2011 22:23:49 -0400 Received: from mga11.intel.com ([192.55.52.93]:24402 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756759Ab1FGCXs (ORCPT ); Mon, 6 Jun 2011 22:23:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,329,1304319600"; d="scan'208";a="12763264" Date: Tue, 7 Jun 2011 10:28:29 +0800 From: Feng Tang To: Dirk Brandewie CC: Grant Likely , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Mike Frysinger Subject: Re: [PATCH v2] spi: reorganize drivers Message-ID: <20110607102829.01392e7e@feng-i7> In-Reply-To: <4DED0510.1030600@gmail.com> References: <20110606071829.10334.90865.stgit@ponder> <4DED0510.1030600@gmail.com> Organization: intel X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; i486-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1856 Lines: 46 On Tue, 7 Jun 2011 00:49:20 +0800 Dirk Brandewie wrote: > On 06/06/2011 09:38 AM, Grant Likely wrote: > > On Mon, Jun 6, 2011 at 10:31 AM, Mike > > Frysinger wrote: > >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote: > >>> Sort the SPI makefile and enforce the naming convention spi_*.c > >>> for spi drivers. > >> > >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but > >> perhaps those are only for /proc/ status tracking ? worth double > >> checking ... > > > > I just talked with Dirk Brandewie, who has a major rewrite to the > > topcliff spi driver. I'll let him comment on whether or not > > changing KBUILD_MODNAME will cause any problems. > > > > My changes are to the designware driver :-) I will get my patches > re-based onto the spi-next branch and see if there any issues. If there is major rewrite to the dw_spi driver, please submit to this list, as it is used by many devices out there and needs a broad review Thanks, Feng > > --Dirk > > ------------------------------------------------------------------------------ > Simplify data backup and recovery for your virtual environment with > vRanger. Installation's a snap, and flexible recovery options mean > your data is safe, secure and there when you need it. Discover what > all the cheering's about. Get your free trial download today. > http://p.sf.net/sfu/quest-dev2dev2 > _______________________________________________ > spi-devel-general mailing list > spi-devel-general@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/spi-devel-general -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/