Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100Ab1FGEpI (ORCPT ); Tue, 7 Jun 2011 00:45:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:29501 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753126Ab1FGEpB convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2011 00:45:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,330,1304319600"; d="scan'208";a="12796373" Date: Tue, 7 Jun 2011 12:48:54 +0800 From: Feng Tang To: Grant Likely CC: Dirk Brandewie , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Mike Frysinger , , , Subject: Re: [PATCH v2] spi: reorganize drivers Message-ID: <20110607124854.0e96813c@feng-i7> In-Reply-To: References: <20110606071829.10334.90865.stgit@ponder> <4DED0510.1030600@gmail.com> <20110607102829.01392e7e@feng-i7> Organization: intel X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; i486-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2256 Lines: 55 Hi Grant, On Tue, 7 Jun 2011 12:09:52 +0800 Grant Likely wrote: > On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang wrote: > > On Tue, 7 Jun 2011 00:49:20 +0800 > > Dirk Brandewie wrote: > > > >> On 06/06/2011 09:38 AM, Grant Likely wrote: > >> > On Mon, Jun 6, 2011 at 10:31 AM, Mike > >> > Frysinger ?wrote: > >> >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote: > >> >>> Sort the SPI makefile and enforce the naming convention spi_*.c > >> >>> for spi drivers. > >> >> > >> >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but > >> >> perhaps those are only for /proc/ status tracking ? ?worth > >> >> double checking ... > >> > > >> > I just talked with Dirk Brandewie, who has a major rewrite to the > >> > topcliff spi driver. ?I'll let him comment on whether or not > >> > changing KBUILD_MODNAME will cause any problems. > >> > > >> > >> My changes are to the designware driver :-) I will get my patches > >> re-based onto the spi-next branch and see if there any issues. > > > > If there is major rewrite to the dw_spi driver, please submit to > > this list, as it is used by many devices out there and needs a > > broad review > > Hmmm. Dirk, that could change things a bit. From our conversation > today my understanding was that there weren't few if any users outside > of your circle. If that isn't the case, then I'm going to be more > cautious about merging the rewrite. Who are the people I should make > sure there is feedback from when the patch gets posted? I don't know all the devices and users, but here is what I know: I've tested Max3110 spi-uart (in-tree), Option GTM501L high-speed 3G modem (out of tree), ektf1236 spi touch screen (out of tree). Alek Du (Cced) should have tested current dw_spi driver with some spi bluetooth device and modem device. Also the original author fordw_spi_mmio.c Jean-Hugues Deschense should have some experience too. Thanks, Feng > > g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/