Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753958Ab1FGEzY (ORCPT ); Tue, 7 Jun 2011 00:55:24 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:40020 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab1FGEzW (ORCPT ); Tue, 7 Jun 2011 00:55:22 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6369"; a="95852648" From: "Tanya Brokhman" To: "'Alan Stern'" Cc: , , , , , "'open list'" References: <1307360469-29120-10-git-send-email-tlinder@codeaurora.org> In-Reply-To: Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter Date: Tue, 7 Jun 2011 07:55:14 +0300 Message-ID: <014201cc24cf$1b3414d0$519c3e70$@org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 thread-index: AcwkX9kd1M8KIopuS8C+SDnBSCoHzwAbizyw Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 26 > > You might want to print out some kind of error message if the user > specifies is_super_speed = True and is_high_speed = False. > I thought about that as well. Even added it but removed at the last minute :) I encountered quite a few places in the code where some error message to the user is really needed but is missing so my impression was that it's best to keep the printks to a minimum. Isn't that the general approach? IMO, in this particular case informing the user isn't a "must". If you feel strongly about it I can add the message. Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/