Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374Ab1FGMwW (ORCPT ); Tue, 7 Jun 2011 08:52:22 -0400 Received: from ppsw-50.csi.cam.ac.uk ([131.111.8.150]:39682 "EHLO ppsw-50.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163Ab1FGMwU (ORCPT ); Tue, 7 Jun 2011 08:52:20 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4DEE20E7.4020008@cam.ac.uk> Date: Tue, 07 Jun 2011 14:00:23 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110509 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: anish CC: gregkh@suse.de, manuel.stahl@iis.fraunhofer.de, lucas.demarchi@profusion.mobi, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Linux I2C Subject: Re: [PATCH] staging iio: Replace kmalloc with local variable References: <1307450354.1516.23.camel@anish-desktop> In-Reply-To: <1307450354.1516.23.camel@anish-desktop> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 41 On 06/07/11 13:39, anish wrote: > From: anish kumar > > replaced kmalloc with local variable as I2C(in this case) doesn't require > kmalloc memory it can do with stack memory. I've cc'd linux-i2c just to check I'm right about the whole i2c doesn't need dma safe buffers bit... > > Signed-off-by: anish kumar Acked-by: Jonathan Cameron > --- > drivers/staging/iio/adc/max1363_core.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c > index 1037087..9462230 100644 > --- a/drivers/staging/iio/adc/max1363_core.c > +++ b/drivers/staging/iio/adc/max1363_core.c > @@ -207,15 +207,12 @@ static int max1363_write_basic_config(struct i2c_client *client, > unsigned char d2) > { > int ret; > - u8 *tx_buf = kmalloc(2, GFP_KERNEL); > + u8 tx_buf[2]; > > - if (!tx_buf) > - return -ENOMEM; > tx_buf[0] = d1; > tx_buf[1] = d2; > > ret = i2c_master_send(client, tx_buf, 2); > - kfree(tx_buf); > > return (ret > 0) ? 0 : ret; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/