Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755922Ab1FGOjJ (ORCPT ); Tue, 7 Jun 2011 10:39:09 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:59363 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755890Ab1FGOjG (ORCPT ); Tue, 7 Jun 2011 10:39:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=b5tc0fRVJAkNBWlBpT/r3uNf9hzWjgt2VDyPmbEF3ozPiARrP1adl78rVeMyxQWvsT lkAgUCc9FXZhsL/TGUcO2tNpY0Nm/Mtm7GY9Sr1NnlXXfVOKw/vdzE1zjv4Q85lvMJ0v 2mXzPIZaYhOsv0rTXTnTVNX663uV5k3jEd2N4= From: Minchan Kim To: Andrew Morton Cc: linux-mm , LKML , KOSAKI Motohiro , Mel Gorman , Andrea Arcangeli , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki , Minchan Kim Subject: [PATCH v3 03/10] Add additional isolation mode Date: Tue, 7 Jun 2011 23:38:16 +0900 Message-Id: X-Mailer: git-send-email 1.7.0.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2243 Lines: 65 There are some places to isolate lru page and I believe users of isolate_lru_page will be growing. The purpose of them is each different so part of isolated pages should put back to LRU, again. The problem is when we put back the page into LRU, we lose LRU ordering and the page is inserted at head of LRU list. It makes unnecessary LRU churning so that vm can evict working set pages rather than idle pages. This patch adds new modes when we isolate page in LRU so we don't isolate pages if we can't handle it. It could reduce LRU churning. This patch doesn't change old behavior. It's just used by next patches. Cc: KOSAKI Motohiro Cc: Mel Gorman Cc: Andrea Arcangeli Cc: KAMEZAWA Hiroyuki Acked-by: Rik van Riel Acked-by: Johannes Weiner Signed-off-by: Minchan Kim --- include/linux/swap.h | 2 ++ mm/vmscan.c | 6 ++++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 48d50e6..731f5dd 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -248,6 +248,8 @@ enum ISOLATE_MODE { ISOLATE_NONE, ISOLATE_INACTIVE = 1, /* Isolate inactive pages */ ISOLATE_ACTIVE = 2, /* Isolate active pages */ + ISOLATE_CLEAN = 8, /* Isolate clean file */ + ISOLATE_UNMAPPED = 16, /* Isolate unmapped file */ }; /* linux/mm/vmscan.c */ diff --git a/mm/vmscan.c b/mm/vmscan.c index 4cbe114..26aa627 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -990,6 +990,12 @@ int __isolate_lru_page(struct page *page, enum ISOLATE_MODE mode, int file) ret = -EBUSY; + if (mode & ISOLATE_CLEAN && (PageDirty(page) || PageWriteback(page))) + return ret; + + if (mode & ISOLATE_UNMAPPED && page_mapped(page)) + return ret; + if (likely(get_page_unless_zero(page))) { /* * Be careful not to clear PageLRU until after we're -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/