Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755458Ab1FGXoB (ORCPT ); Tue, 7 Jun 2011 19:44:01 -0400 Received: from one.firstfloor.org ([213.235.205.2]:36216 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754976Ab1FGXoA (ORCPT ); Tue, 7 Jun 2011 19:44:00 -0400 Date: Wed, 8 Jun 2011 01:43:56 +0200 From: Andi Kleen To: "Paul E. McKenney" Cc: Thomas Gleixner , Andi Kleen , linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/5] Fix mismatched variable in rcutree_trace.c Message-ID: <20110607234356.GA27166@one.firstfloor.org> References: <1307485593-27196-1-git-send-email-andi@firstfloor.org> <1307485593-27196-2-git-send-email-andi@firstfloor.org> <20110607231306.GH2286@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110607231306.GH2286@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 638 Lines: 14 > Hmmm... Some arches have signed CPU numbers while others have unsigned > CPU numbers. I do use "-1" to mean "no CPU" in some cases (for example, > in rcu_node_kthread_setaffinity()), so I guess for consistency I should > be using "int" everywhere. Do I hear that "int" is ok for you? If yes I will not revise the patch and please merge it. If it needs changes please let me know. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/