Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728Ab1FHJRr (ORCPT ); Wed, 8 Jun 2011 05:17:47 -0400 Received: from casper.infradead.org ([85.118.1.10]:39238 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751029Ab1FHJRq (ORCPT ); Wed, 8 Jun 2011 05:17:46 -0400 Subject: Re: [PATCH 4/4] x86: intel-iommu: move to drivers/iommu/ From: David Woodhouse To: Ohad Ben-Cohen Cc: Joerg Roedel , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , David Brown , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org Date: Wed, 08 Jun 2011 10:17:38 +0100 In-Reply-To: <1307522062-19273-5-git-send-email-ohad@wizery.com> References: <1307522062-19273-1-git-send-email-ohad@wizery.com> <1307522062-19273-5-git-send-email-ohad@wizery.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3 Content-Transfer-Encoding: 7bit Message-ID: <1307524659.4771.12.camel@i7.infradead.org> Mime-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 31 On Wed, 2011-06-08 at 11:34 +0300, Ohad Ben-Cohen wrote: > --- a/drivers/pci/Makefile > +++ b/drivers/pci/Makefile > @@ -30,7 +30,7 @@ obj-$(CONFIG_PCI_MSI) += msi.o > obj-$(CONFIG_HT_IRQ) += htirq.o > > # Build Intel IOMMU support > -obj-$(CONFIG_DMAR) += dmar.o iova.o intel-iommu.o > +obj-$(CONFIG_DMAR) += dmar.o iova.o > > obj-$(CONFIG_INTR_REMAP) += dmar.o intr_remapping.o > At least iova.o wants to go with it. That's one of the parts that is a candidate for harmonisation across IOMMU implementations, either by removing it or by having others use it too. It's how we allocate virtual I/O address space. I suspect the interrupt remapping support may well want to move with it too. It's no more out-of-place in drivers/iommu than it is in drivers/pci. And then you can certainly move dmar.o too. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/