Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756623Ab1FHXAL (ORCPT ); Wed, 8 Jun 2011 19:00:11 -0400 Received: from mail160.messagelabs.com ([216.82.253.99]:27357 "EHLO mail160.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103Ab1FHXAJ convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2011 19:00:09 -0400 X-VirusChecked: Checked X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-15.tower-160.messagelabs.com!1307573934!25170303!63 X-StarScan-Version: 6.2.17; banners=-,-,- X-Originating-IP: [216.166.12.178] From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH v3] cpuinfo_op: consolidate extern declaration Date: Wed, 8 Jun 2011 15:59:42 -0700 User-Agent: KMail/1.9.9 CC: , , , , , , , , , , , , MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-ID: <201106081559.42931.hartleys@visionengravers.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4357 Lines: 130 All the architectures supported by the kernel also support /proc/cpuinfo. Only a couple actually declare the seq_operations as extern. All the others will produce a sparse warning like: warning: symbol 'cpuinfo_op' was not declared. Should it be static? Fix all the warnings and consolidate the declaration by putting it in . Signed-off-by: H Hartley Sweeten Tested-by: Michal Simek Acked-by: Paul Mundt Cc: "David S. Miller" Cc: Chris Metcalf Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Magnus Damm Cc: Arnd Bergmann Cc: Hans Rosenfeld Cc: Len Brown Cc: Borislav Petkov Cc: Tejun Heo --- v3: bah... fix typo v2: updated to latest linux-next and added sign offs       original patch was posted Jan 14, 2010 diff --git a/arch/microblaze/include/asm/processor.h b/arch/microblaze/include/asm/processor.h index aed2a6b..9ded678 100644 --- a/arch/microblaze/include/asm/processor.h +++ b/arch/microblaze/include/asm/processor.h @@ -18,8 +18,6 @@ #include # ifndef __ASSEMBLY__ -/* from kernel/cpu/mb.c */ -extern const struct seq_operations cpuinfo_op; # define cpu_relax() barrier() # define cpu_sleep() do {} while (0) diff --git a/arch/sh/include/asm/processor.h b/arch/sh/include/asm/processor.h index 9c7bdfc..ba300ee 100644 --- a/arch/sh/include/asm/processor.h +++ b/arch/sh/include/asm/processor.h @@ -127,7 +127,6 @@ extern unsigned int mem_init_done; /* arch/sh/kernel/setup.c */ const char *get_cpu_subtype(struct sh_cpuinfo *c); -extern const struct seq_operations cpuinfo_op; /* thread_struct flags */ #define SH_THREAD_UAC_NOPRINT (1 << 0) diff --git a/arch/sparc/include/asm/cpudata_64.h b/arch/sparc/include/asm/cpudata_64.h index 050ef35..ac3996b 100644 --- a/arch/sparc/include/asm/cpudata_64.h +++ b/arch/sparc/include/asm/cpudata_64.h @@ -35,8 +35,6 @@ DECLARE_PER_CPU(cpuinfo_sparc, __cpu_data); #define cpu_data(__cpu) per_cpu(__cpu_data, (__cpu)) #define local_cpu_data() __get_cpu_var(__cpu_data) -extern const struct seq_operations cpuinfo_op; - #endif /* !(__ASSEMBLY__) */ #include diff --git a/arch/tile/include/asm/processor.h b/arch/tile/include/asm/processor.h index 34c1e01..d95fcc7 100644 --- a/arch/tile/include/asm/processor.h +++ b/arch/tile/include/asm/processor.h @@ -257,10 +257,6 @@ static inline void cpu_relax(void) barrier(); } -/* Info on this processor (see fs/proc/cpuinfo.c) */ -struct seq_operations; -extern const struct seq_operations cpuinfo_op; - /* Provide information about the chip model. */ extern char chip_model[64]; diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 2193715..98eb12d 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -142,8 +142,6 @@ DECLARE_PER_CPU_SHARED_ALIGNED(struct cpuinfo_x86, cpu_info); #define cpu_data(cpu) boot_cpu_data #endif -extern const struct seq_operations cpuinfo_op; - static inline int hlt_works(int cpu) { #ifdef CONFIG_X86_32 diff --git a/fs/proc/cpuinfo.c b/fs/proc/cpuinfo.c index 5a1e539..f8eea8e 100644 --- a/fs/proc/cpuinfo.c +++ b/fs/proc/cpuinfo.c @@ -3,7 +3,6 @@ #include #include -extern const struct seq_operations cpuinfo_op; static int cpuinfo_open(struct inode *inode, struct file *file) { return seq_open(file, &cpuinfo_op); diff --git a/include/linux/seq_file.h b/include/linux/seq_file.h index 03c0232..46e90eb 100644 --- a/include/linux/seq_file.h +++ b/include/linux/seq_file.h @@ -33,6 +33,12 @@ struct seq_operations { int (*show) (struct seq_file *m, void *v); }; +/* + * All architectures support /proc/cpuinfo + * Define the seq_operations here to keep things clean. + */ +extern const struct seq_operations cpuinfo_op; + #define SEQ_SKIP 1 /** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/