Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756614Ab1FIHSa (ORCPT ); Thu, 9 Jun 2011 03:18:30 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:37660 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827Ab1FIHS1 (ORCPT ); Thu, 9 Jun 2011 03:18:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=fhIvIEa9AXD2sxCMng9n/5EYXZ/qKVPFCt02LJrsPJHwpAIjIQmtszb4PR4NIj7CbT zWTHl6pQAwCnPY/5ob+osoixpjG60MNI3D54Y5k6OXZMo+50bhWHyf325HLTtiF6/HgO 3pa/qbC/gOVR7M+qfelZvdPA31Eju8jt2HURE= From: Weiping Pan To: fubar@us.ibm.com, andy@greyhouse.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Weiping Pan Subject: [PATCH v4 net-next 0/5] bonding:use latest lacp_rate and ad_select and delete unused ad_timer and arp_mon_pt Date: Thu, 9 Jun 2011 15:19:00 +0800 Message-Id: X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 44 There is bug that when you modify lacp_rate via sysfs, 802.3ad won't use the new value of lacp_rate to transmit packets. This is because port->actor_oper_port_state isn't changed. As for ad_select, it can work, but both struct bond_params and ad_bond_info have lacp_fast and ad_select, they are duplicate and need extra synchronization. 802.3ad can get them from bond_params directly every time. And ad_timer and arp_mon_pt aren't used any more, just delete them. changelog: v2: add bond_3ad_update_lacp_rate() as a helper function, and hold bond->lock when iterates slave list. v3: delete duplicate lacp_fast and agg_select_mode from struct ad_bond_info. v4: delete unused ad_timer and arp_mon_pt. Weiping Pan (5): bonding: make 802.3ad use latest lacp_rate bonding:delete lacp_fast from ad_bond_info bonding:delete agg_select_mode from ad_bond_info bonding: delete unused ad_timer bonding: delete unused arp_mon_pt drivers/net/bonding/bond_3ad.c | 41 ++++++++++++++++++++++++++++++++----- drivers/net/bonding/bond_3ad.h | 8 +----- drivers/net/bonding/bond_main.c | 3 +- drivers/net/bonding/bond_sysfs.c | 1 + drivers/net/bonding/bonding.h | 1 - 5 files changed, 39 insertions(+), 15 deletions(-) -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/