Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753515Ab1FIJbs (ORCPT ); Thu, 9 Jun 2011 05:31:48 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:33795 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147Ab1FIJbq (ORCPT ); Thu, 9 Jun 2011 05:31:46 -0400 Date: Thu, 9 Jun 2011 05:31:29 -0400 From: Christoph Hellwig To: Johannes Weiner Cc: Rik van Riel , Hiroyuki Kamezawa , KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Ying Han , Michal Hocko , Andrew Morton , Minchan Kim , KOSAKI Motohiro , Mel Gorman , Greg Thelen , Michel Lespinasse , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 0/8] mm: memcg naturalization -rc2 Message-ID: <20110609093129.GA17072@infradead.org> References: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> <20110602073335.GA20630@cmpxchg.org> <20110602100007.GB20725@cmpxchg.org> <4DF01EC2.8010105@redhat.com> <20110609084300.GD11603@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110609084300.GD11603@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 21 On Thu, Jun 09, 2011 at 10:43:00AM +0200, Johannes Weiner wrote: > I think it's much more natural to do it that way, but it's not a > requirement as such. We could just keep the extra soft limit reclaim > invocation in kswapd that looks for the biggest offender and the > hierarchy below it, then does a direct call to do_shrink_zone() to > bypass the generic hierarchy walk. > > It's not very nice to have that kind of code duplication, but it's > possible to leave it like that for now. Unless there is a really good reason please kill it. It just means more codepathes that eat away tons of stack in the reclaim path, and we already have far too much of those, and more code that needs fixing for all the reclaim issues we have. Nevermind that the cgroups code generally gets a lot less testing, so the QA overhead is also much worse. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/