Subject: Re: [PATCH 14/15] gma500: nuke the PSB debug stuff
From: Dave Airlie <airlied@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>, greg@kroah.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Date: Thu, 09 Jun 2011 20:36:51 +1000
In-Reply-To: <20110609091103.4b61f2a1@lxorguk.ukuu.org.uk>
References: <20110608100411.9478.86672.stgit@localhost.localdomain>
	 <20110608101515.9478.67943.stgit@localhost.localdomain>
	 <BANLkTikYtLExBTcYAwicjEH=1bQp28WitQ@mail.gmail.com>
	 <20110609091103.4b61f2a1@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Message-ID: <1307615814.5963.2.camel@t60prh>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 988
Lines: 27

On Thu, 2011-06-09 at 09:11 +0100, Alan Cox wrote:
> On Thu, 9 Jun 2011 03:10:03 +0200
> Patrik Jakobsson <patrik.r.jakobsson@gmail.com> wrote:
> 
> > Hi Alan
> > 
> > Just a thought. Shouldn't we use the DRM macros for printing debug info?
> 
> Linux has perfectly good printing functions and using them means we can
> use dev_dbg() which supports things like nice runtime switching.

You mean like the drm debug functions runtime switching? that predated
the kernel ones and nobody ever ported :-)

Though if psb wants to be different to other drm drivers it can lead the
way, though it'll be a total nightmare for all the people who follow
documentation on how to debug drm drivers using drm.debug=1,2,4,8. for
various code paths.

Dave.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/