Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754509Ab1FIKig (ORCPT ); Thu, 9 Jun 2011 06:38:36 -0400 Received: from ppsw-41.csi.cam.ac.uk ([131.111.8.141]:34350 "EHLO ppsw-41.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752827Ab1FIKie (ORCPT ); Thu, 9 Jun 2011 06:38:34 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4DF0A48B.6040802@cam.ac.uk> Date: Thu, 09 Jun 2011 11:46:35 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110509 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Jonathan Cameron CC: anish singh , Jean Delvare , Ben Dooks , gregkh@suse.de, manuel.stahl@iis.fraunhofer.de, lucas.demarchi@profusion.mobi, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Linux I2C Subject: Re: [PATCH] staging iio: Replace kmalloc with local variable References: <1307450354.1516.23.camel@anish-desktop> <4DEE20E7.4020008@cam.ac.uk> <20110607134135.GD15795@trinity.fluff.org> <20110607160206.6cb3168d@endymion.delvare> <20110609102948.7a3f8d57@endymion.delvare> <4DF088E5.5000408@cam.ac.uk> In-Reply-To: <4DF088E5.5000408@cam.ac.uk> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1875 Lines: 40 On 06/09/11 09:48, Jonathan Cameron wrote: > On 06/09/11 09:34, anish singh wrote: >> >> >> On Thu, Jun 9, 2011 at 1:59 PM, Jean Delvare > wrote: >> >> On Thu, 9 Jun 2011 13:53:09 +0530, anish singh wrote: >> > On Wed, Jun 8, 2011 at 10:41 AM, anish singh >wrote: >> > > On Tue, Jun 7, 2011 at 7:32 PM, Jean Delvare > wrote: >> > >> To be clearer, it is down to the i2c BUS (adapter) driver, NOT the i2c >> > >> device driver. So the patch is correct. >> > >> >> > > I think i can take Jean ack on this?If yes then Joanthan kindly apply >> > > this patch and i think you didn't lead me in wrong way as whatever >> > > said by you is corroborated by jean also i.e. it is I2C bus driver >> > > responsiblity >> > > to care about DMA. >> > > >> > Sorry to ping you again.Can i take your ack on this? >> >> Yes of course. >> >> Acked-by: Jean Delvare > >> >> Thanks a ton.Jonathan kindly apply it now :) > Greg, I'll send this one on to you with the set I currently have out for review. > Doh, after all this, I just tried to apply this to find the code in question has already gone. Anish, what tree are you working against? Looks like I did an equivalent clean up (with a load of others) back in May then forgot about it. Sorry all. I should have actually have checked it was still relevant rather than reviewing purely on basis of content of patch... Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/