DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        b=UK8SlP1do31ksgO26HgBl944UQq0ScpjZqmX9wH0WF4/W+fJRDzgEz8Imc4hQZKwHs
         AA2YKPvio405x/ip1A9T3Hykq9LaHZ9Wkau9fS6Y8/yJkPeftzKq2RhtJreJUxqmKCKr
         iJiGHL8ogni0BfkSJTUPUapFD07A68IoNSyyE=
MIME-Version: 1.0
In-Reply-To: <4DF0A8B3.8090900@mev.co.uk>
References: <20110609092401.GA2777@mail.fossee.in> <4DF0A8B3.8090900@mev.co.uk>
From: Prashant Shah <pshah.mumbai@gmail.com>
Date: Thu, 9 Jun 2011 17:10:55 +0530
Message-ID: <BANLkTim-bgWFVnp1Q9QqU2t5=-v7jg6jCw@mail.gmail.com>
Subject: Re: [PATCH 1/2] Staging: comedi: add dyna_pci10xx driver
To: Ian Abbott <abbotti@mev.co.uk>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        Greg Kroah-Hartman <gregkh@suse.de>,
        Frank Mori Hess <fmhess@users.sourceforge.net>,
        Ian Abbott <ian.abbott@mev.co.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 769
Lines: 24

Hi Ian,

On Thu, Jun 9, 2011 at 4:34 PM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 09/06/11 10:24, Prashant P. Shah wrote:

> It looks mostly okay to me as long as you got the PCI device ID
> allocated by PLX (which they'll happily do for their customers if you
> tell them what product the chip is is part of), and didn't just pull it
> out of a hat!

I will forward that to the vendor...

> I have a few more specific comments on the code (not many!):
> Best regards,
> Ian.

fixed and sent patch for the same.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/