Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494Ab1FIOlW (ORCPT ); Thu, 9 Jun 2011 10:41:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab1FIOlV (ORCPT ); Thu, 9 Jun 2011 10:41:21 -0400 Message-ID: <4DF0DB8D.5080207@redhat.com> Date: Thu, 09 Jun 2011 10:41:17 -0400 From: Peter Jones User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Matthew Garrett , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE References: <1307629964-31658-1-git-send-email-mjg@redhat.com> <4DF0DAAB.7010005@zytor.com> In-Reply-To: <4DF0DAAB.7010005@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 37 On 06/09/2011 10:37 AM, H. Peter Anvin wrote: > On 06/09/2011 07:32 AM, Matthew Garrett wrote: >> EFI doesn't provide any guarantees that any given address will be free, >> so the bootloader must have the freedom to position the kernel >> appropriately. Make CONFIG_EFI select CONFIG_RELOCATABLE in order to >> ensure that this constraint is satisfiable. >> >> Signed-off-by: Matthew Garrett >> --- >> arch/x86/Kconfig | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index da34972..580cd31 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -1454,6 +1454,7 @@ config ARCH_USES_PG_UNCACHED >> config EFI >> bool "EFI runtime service support" >> depends on ACPI >> + select RELOCATABLE >> ---help--- >> This enables the kernel to use EFI runtime services that are >> available (such as the EFI variable services). > > Can we make this a depends on instead of select? Seems weird to me - when you're configuring the kernel, you're more likely to know that you want EFI than to remember that that requires relocation. -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/