Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754202Ab1FIPwN (ORCPT ); Thu, 9 Jun 2011 11:52:13 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:57323 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754060Ab1FIPwL (ORCPT ); Thu, 9 Jun 2011 11:52:11 -0400 Message-ID: <4DF0EC00.9020603@linux.vnet.ibm.com> Date: Thu, 09 Jun 2011 08:51:28 -0700 From: Wayne Boyer User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Julia Lawall CC: Brian King , kernel-janitors@vger.kernel.org, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/scsi/ipr.c: reorder error handling code to include iounmap References: <1306851409-14963-1-git-send-email-julia@diku.dk> In-Reply-To: <1306851409-14963-1-git-send-email-julia@diku.dk> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2342 Lines: 64 On 05/31/2011 07:16 AM, Julia Lawall wrote: > From: Julia Lawall > > The out_msi_disable label should be before cleanup_nomem to additionally > benefit from the call to iounmap. Yes, this is a problem. I propose the following patch instead. --- In the case where ipr_test_msi returns an error that is not -EOPNOTSUPP, the execution jumps to the out_msi_disable label. This misses the call to iounmap for ipr_regs which was initialized earlier. The fix is to do the call to pci_disable_msi when the error case is detected and then goto the cleanup_nomem label if the error is not -EOPNOTSUPP. Signed-off-by: Wayne Boyer --- drivers/scsi/ipr.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) Index: b/drivers/scsi/ipr.c =================================================================== --- a/drivers/scsi/ipr.c 2011-06-09 08:14:44.927740117 -0700 +++ b/drivers/scsi/ipr.c 2011-06-09 08:50:10.105630466 -0700 @@ -8763,11 +8763,11 @@ static int __devinit ipr_probe_ioa(struc /* Enable MSI style interrupts if they are supported. */ if (ioa_cfg->ipr_chip->intr_type == IPR_USE_MSI && !pci_enable_msi(pdev)) { rc = ipr_test_msi(ioa_cfg, pdev); - if (rc == -EOPNOTSUPP) + if (rc) { pci_disable_msi(pdev); - else if (rc) - goto out_msi_disable; - else + if (rc != -EOPNOTSUPP) + goto cleanup_nomem; + } else dev_info(&pdev->dev, "MSI enabled with IRQ: %d\n", pdev->irq); } else if (ipr_debug) dev_info(&pdev->dev, "Cannot enable MSI.\n"); @@ -8847,8 +8847,6 @@ cleanup_nolog: ipr_free_mem(ioa_cfg); cleanup_nomem: iounmap(ipr_regs); -out_msi_disable: - pci_disable_msi(pdev); out_release_regions: pci_release_regions(pdev); out_scsi_host_put: -- Wayne Boyer IBM - Beaverton, Oregon LTC S/W Development (503) 578-5236, T/L 775-5236 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/