Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756168Ab1FIVXM (ORCPT ); Thu, 9 Jun 2011 17:23:12 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:56447 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752870Ab1FIVXK (ORCPT ); Thu, 9 Jun 2011 17:23:10 -0400 Date: Thu, 9 Jun 2011 17:23:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tanya Brokhman cc: greg@kroah.com, , , , , "'open list'" Subject: RE: [PATCH v2] usb:dummy_hcd: Force FS device connection according to module parameter In-Reply-To: <027301cc26e7$b5c99690$215cc3b0$@org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 27 On Thu, 9 Jun 2011, Tanya Brokhman wrote: > > > + if (!mod_data.is_high_speed && mod_data.is_super_speed) > > > + return -EINVAL; > > > > Print an error message in the log so that the user will know why the > > failure occurred. > > > > But when the module fails to load the message sais that it's invalid > parameter (or something like that). That's why I thought it will be enough. Oh yes, that's true. > You mean to add something that explains WHY these values are wrong? That's what I had in mind. But "invalid parameter" is probably good enough, since these are the _only_ parameters. :-) So this part is okay as it stands. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/