Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932094Ab1FIXD2 (ORCPT ); Thu, 9 Jun 2011 19:03:28 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:40423 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756550Ab1FIXDZ (ORCPT ); Thu, 9 Jun 2011 19:03:25 -0400 Date: Fri, 10 Jun 2011 00:03:22 +0100 From: Al Viro To: David Miller Cc: jj@chaosbits.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RFC] Sparc: Remove trigraph in die_if_kernel() message. Message-ID: <20110609230322.GY11521@ZenIV.linux.org.uk> References: <20110609.155943.162785602513776337.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110609.155943.162785602513776337.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 15 On Thu, Jun 09, 2011 at 03:59:43PM -0700, David Miller wrote: > > If I'm not mistaken, that "??!" will be taken as a trigraph for "|" by the > > preprocessor, so the final string will end up either as > > "Penguin instruction from Penguin mode|?!" Not without -trigraphs, which is not on by default... > Applied, thanks Jesper :-) BTW, idiomatic way to deal with those is to use \? instead of string concat... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/