Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427Ab1FJDOL (ORCPT ); Thu, 9 Jun 2011 23:14:11 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:58233 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862Ab1FJDOH (ORCPT ); Thu, 9 Jun 2011 23:14:07 -0400 Subject: Re: [PATCH] unicore32: fix build error for find bitops From: Guan Xuetao Reply-To: gxt@mprc.pku.edu.cn To: Akinobu Mita Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, greg@kroah.com In-Reply-To: References: <1307617752-23426-1-git-send-email-gxt@mprc.pku.edu.cn> Content-Type: text/plain; charset="UTF-8" Organization: MPRC, PKU Date: Fri, 10 Jun 2011 11:13:47 +0800 Message-ID: <1307675627.1537.5.camel@epip-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2041 Lines: 52 On Thu, 2011-06-09 at 20:32 +0900, Akinobu Mita wrote: > 2011/6/9 GuanXuetao : > > From: Guan Xuetao > > > > Remove the __uc32_ prefix in find bitops functions. > > see commit <19de85ef574c3a2182e3ccad9581805052f14946> > > bitops: add #ifndef for each of find bitops > > > > Signed-off-by: Guan Xuetao > > Cc: Akinobu Mita > > --- > > arch/unicore32/include/asm/bitops.h | 6 ------ > > arch/unicore32/kernel/ksyms.c | 4 ++-- > > arch/unicore32/lib/findbit.S | 14 ++++++++------ > > 3 files changed, 10 insertions(+), 14 deletions(-) > > > > diff --git a/arch/unicore32/include/asm/bitops.h b/arch/unicore32/include/asm/bitops.h > > index 1628a63..a9653f0 100644 > > --- a/arch/unicore32/include/asm/bitops.h > > +++ b/arch/unicore32/include/asm/bitops.h > > @@ -13,12 +13,6 @@ > > #ifndef __UNICORE_BITOPS_H__ > > #define __UNICORE_BITOPS_H__ > > > > -#define find_next_bit __uc32_find_next_bit > > -#define find_next_zero_bit __uc32_find_next_zero_bit > > - > > -#define find_first_bit __uc32_find_first_bit > > -#define find_first_zero_bit __uc32_find_first_zero_bit > > - > > Is this patch really fix the build error? > > If these find_*_bit macros are removed, vmlinux will have multiple > definisions of find_*_bit. Because lib/find_next_bit.c is built > unconditionally after the commit 63e424c84429903c92a0f1e9654c31ccaf6694d0 > ("arch: remove CONFIG_GENERIC_FIND_{NEXT_BIT,BIT_LE,LAST_BIT}". Yes, the patch really 'eliminate' the build error. However, when I checked binary code in vmlinux, it definitely uses the functions in lib/find*.c, but not the assembly implementations in arch/unicore32/lib/findbit.S. Thanks & Regards, Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/