Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752437Ab1FJF3H (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2011 01:29:07 -0400
Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:36371 "EHLO
	fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750854Ab1FJF3D (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2011 01:29:03 -0400
X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1
Date: Fri, 10 Jun 2011 14:22:03 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Xiaotian Feng <xtfeng@gmail.com>
Cc: Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>,
        Dave Jones <davej@redhat.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Oleg Nesterov <oleg@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH] [BUGFIX] update mm->owner even if no next owner.
Message-Id: <20110610142203.f2d6c922.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <BANLkTi=_-md7tes5GPcYh5Bpd=g_FVaagw@mail.gmail.com>
References: <20110609212956.GA2319@redhat.com>
	<BANLkTikCfWhoLNK__ringzy7KjKY5ZEtNb3QTuX1jJ53wNNysA@mail.gmail.com>
	<BANLkTikF7=qfXAmrNzyMSmWm7Neh6yMAB8EbBp7oLcfQmrbDjA@mail.gmail.com>
	<20110610091355.2ce38798.kamezawa.hiroyu@jp.fujitsu.com>
	<alpine.LSU.2.00.1106091812030.4904@sister.anvils>
	<20110610113311.409bb423.kamezawa.hiroyu@jp.fujitsu.com>
	<20110610121949.622e4629.kamezawa.hiroyu@jp.fujitsu.com>
	<20110610125551.385ea7ed.kamezawa.hiroyu@jp.fujitsu.com>
	<20110610133021.2eaaf0da.kamezawa.hiroyu@jp.fujitsu.com>
	<BANLkTi=_-md7tes5GPcYh5Bpd=g_FVaagw@mail.gmail.com>
Organization: FUJITSU Co. LTD.
X-Mailer: Sylpheed 3.1.0 (GTK+ 2.10.14; i686-pc-mingw32)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2313
Lines: 65

On Fri, 10 Jun 2011 13:21:46 +0800
Xiaotian Feng <xtfeng@gmail.com> wrote:

> On Fri, Jun 10, 2011 at 12:30 PM, KAMEZAWA Hiroyuki <
> kamezawa.hiroyu@jp.fujitsu.com> wrote:
> 
> >
> > I think this can be a fix.
> > maybe good to CC Oleg.
> 
> ==
> > From dff52fb35af0cf36486965d19ee79e04b59f1dc4 Mon Sep 17 00:00:00 2001
> > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Date: Fri, 10 Jun 2011 13:15:14 +0900
> > Subject: [PATCH] [BUGFIX] update mm->owner even if no next owner.
> >
> > A panic is reported.
> >
> > > Call Trace:
> > >  [<ffffffff81139792>] mem_cgroup_from_task+0x15/0x17
> > >  [<ffffffff8113a75a>] __mem_cgroup_try_charge+0x148/0x4b4
> > >  [<ffffffff810493f3>] ? need_resched+0x23/0x2d
> > >  [<ffffffff814cbf43>] ? preempt_schedule+0x46/0x4f
> > >  [<ffffffff8113afe8>] mem_cgroup_charge_common+0x9a/0xce
> > >  [<ffffffff8113b6d1>] mem_cgroup_newpage_charge+0x5d/0x5f
> > >  [<ffffffff81134024>] khugepaged+0x5da/0xfaf
> > >  [<ffffffff81078ea0>] ? __init_waitqueue_head+0x4b/0x4b
> > >  [<ffffffff81133a4a>] ? add_mm_counter.constprop.5+0x13/0x13
> > >  [<ffffffff81078625>] kthread+0xa8/0xb0
> > >  [<ffffffff814d13e8>] ? sub_preempt_count+0xa1/0xb4
> > >  [<ffffffff814d5664>] kernel_thread_helper+0x4/0x10
> > >  [<ffffffff814ce858>] ? retint_restore_args+0x13/0x13
> > >  [<ffffffff8107857d>] ? __init_kthread_worker+0x5a/0x5a
> >
> > The code is.
> > >         return container_of(task_subsys_state(p, mem_cgroup_subsys_id),
> > >                                 struct mem_cgroup, css);
> >
> >
> > What happens here is accssing a freed task struct "p" from mm->owner.
> > So, it's doubtful that mm->owner points to freed task struct.
> >
> >
> But from the bug itself, it looks more likely kernel is hitting a freed
> p->cgroups, right?
> If p is already freed, the kernel will fault on
> 781cc62d: 8b 82 fc 08 00 00       mov    0x8fc(%edx),%eax
> 
> Then you will not get a value of 6b6b6b87, right?


%edx here is a pointer for task struct.
Then, task->cgroup == 0x6b6b6b6b. It means "task" is freed.

Thanks,
-Kame




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/