Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811Ab1FJGk7 (ORCPT ); Fri, 10 Jun 2011 02:40:59 -0400 Received: from smtp-out.google.com ([216.239.44.51]:17514 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027Ab1FJGk5 (ORCPT ); Fri, 10 Jun 2011 02:40:57 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=TrTcuAWTmEFlT+UpLnQpH8AVvRr/3iCLfgah/aQrdF2j0uCS0UQeVY0v/nUZZifaOq nTHKq/kuoH8VPR3ks+kw== Date: Thu, 9 Jun 2011 23:40:38 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@sister.anvils To: Shaohua Li cc: Andrew Morton , "Zhang, Yanmin" , Tim Chen , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 5/7] tmpfs: simplify prealloc_page In-Reply-To: <1307671323.15392.76.camel@sli10-conroe> Message-ID: References: <1307671323.15392.76.camel@sli10-conroe> User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 19 On Fri, 10 Jun 2011, Shaohua Li wrote: > On Fri, 2011-06-10 at 06:39 +0800, Hugh Dickins wrote: > > @@ -1492,11 +1460,19 @@ repeat: > > SetPageUptodate(filepage); > > if (sgp == SGP_DIRTY) > > set_page_dirty(filepage); > > + } else { > Looks info->lock unlock is missed here. > Otherwise looks good to me. Many thanks for catching that! Replacements for this patch, and the next which then rejects, follow as replies. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/