Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854Ab1FJGme (ORCPT ); Fri, 10 Jun 2011 02:42:34 -0400 Received: from mail-iw0-f174.google.com ([209.85.214.174]:39919 "EHLO mail-iw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634Ab1FJGmc convert rfc822-to-8bit (ORCPT ); Fri, 10 Jun 2011 02:42:32 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=q87vCh2EAjFuXfd+AgjonX7WvK/is2/IWNuRWY5pBeme2FaC16AUSYe4Fwv9Z0vIgm yPGd0c4q+2U7affLTpxuoYrCXVAXHEBVlMB7qA0sggzMVbgG6UKB2X3lMUkiu6tMl2oK Y0XoKCnNjP0wewdNzQ7BtAxdZbrcYy0sFvTiU= MIME-Version: 1.0 In-Reply-To: <20110610052047.GB3643@gmail.com> References: <20110609030401.GA2615@gmail.com> <20110609103747.59805668.randy.dunlap@oracle.com> <20110610052047.GB3643@gmail.com> Date: Thu, 9 Jun 2011 23:42:30 -0700 Message-ID: Subject: Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x_edac.c From: Connor Hansen To: Randy Dunlap , linux-kernel@vger.kernel.org, arvino55@gmail.com Cc: ravi@jetztechnologies.com, bluesmoke-devel@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3767 Lines: 111 My system is 64bit, thus not showing a warning adding cc to maintainer, and dev list 2011/6/9 Harry Wei : > On Thu, Jun 09, 2011 at 10:37:47AM -0700, Randy Dunlap wrote: >> On Thu, 9 Jun 2011 11:04:13 +0800 Harry Wei wrote: >> >> > -   page = (unsigned long) info->eap; >> > +   page = (unsigned long long) info->eap; >> >> But page is still unsigned long, not unsigned long long... > Yup, but if we can define a 'unsigned long long' type? >> >> >     if (info->xeap & 1) >> > -           page |= 0x100000000ul; >> > +           page |= 0x100000000ull; >> >> and just making this second change fixes the warning. > I will try my best. Can anyone give some other comments? >> >> I don't know what the right answer is, but this patch does not look >> complete to me. > I will try to give a v2. >> >> Back in April there was a discussion about this warning message and the >> conclusion was that this driver should be replaced.  See >> https://lkml.org/lkml/2011/4/21/232 and its replies. >> But we seem to be having problems reaching the EDAC subsystem maintainer >> (again cc-ed). > You have not got a exact conclusion about this warning. > Maybe Arvind knows more about this warning.(cc'ed) > > > Thanks > Harry Wei > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html > Please read the FAQ at  http://www.tux.org/lkml/ > older convo for new cc's On Thu, 9 Jun 2011 11:04:13 +0800 Harry Wei wrote: > From: Harry Wei > > When i compile 2.6.39.1, a warning shows like below. > This patch can fix the warning. And i works well with > my PC. > > [...] > CC [M] drivers/edac/e752x_edac.o > CC [M] drivers/edac/i82875p_edac.o > CC [M] drivers/edac/i82975x_edac.o > drivers/edac/i82975x_edac.c: In function ���i82975x_process_error_info���: > drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for ���unsigned long��� type > CC [M] drivers/edac/i3000_edac.o > CC [M] drivers/edac/i3200_edac.o > CC [M] drivers/edac/x38_edac.o > CC [M] drivers/edac/i82860_edac.o > [...] > > > Signed-off-by: Harry Wei > Index: prj/drivers/edac/i82975x_edac.c > =================================================================== > --- prj.orig/drivers/edac/i82975x_edac.c 2011-06-04 10:09:55.351174516 +0800 > +++ prj/drivers/edac/i82975x_edac.c 2011-06-04 10:10:30.875168437 +0800 > @@ -293,9 +293,9 @@ > info->errsts = info->errsts2; > } > > - page = (unsigned long) info->eap; > + page = (unsigned long long) info->eap; But page is still unsigned long, not unsigned long long... > if (info->xeap & 1) > - page |= 0x100000000ul; > + page |= 0x100000000ull; and just making this second change fixes the warning. I don't know what the right answer is, but this patch does not look complete to me. Back in April there was a discussion about this warning message and the conclusion was that this driver should be replaced. See https://lkml.org/lkml/2011/4/21/232 and its replies. But we seem to be having problems reaching the EDAC subsystem maintainer (again cc-ed). > chan = page & 1; > page >>= 1; > offst = page & ((1 << PAGE_SHIFT) - 1); > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - Show quoted text - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/