Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757104Ab1FJNAl (ORCPT ); Fri, 10 Jun 2011 09:00:41 -0400 Received: from cantor.suse.de ([195.135.220.2]:53150 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085Ab1FJNAj (ORCPT ); Fri, 10 Jun 2011 09:00:39 -0400 Date: Fri, 10 Jun 2011 15:00:38 +0200 (CEST) From: Jiri Kosina To: Andrew Murray Cc: linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Murray , Arjan van de Ven Subject: Re: [PATCH] Bootgraph.pl bug fix In-Reply-To: <1307655610-28446-1-git-send-email-amurray@mpcdata.com> Message-ID: References: <1307655610-28446-1-git-send-email-amurray@mpcdata.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 45 On Thu, 9 Jun 2011, Andrew Murray wrote: > This patch removes the assumption of the bootgraph.pl script that the > timing information reported by PRINTK_TIME will contain at least one > entry with a time of less than 100 seconds. > > Not all boards correctly reset the system timer and in many cases the > inital times reported by PRINTK_TIME is high. When this occurs the > bootchart.pl script fails to give any useful output. > > This patch sets the $firsttime variable to the largest value expected > by PRINTK_TIME > > Signed-off-by: Andrew Murray > --- > scripts/bootgraph.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/bootgraph.pl b/scripts/bootgraph.pl > index 12caa82..b78fca9 100644 > --- a/scripts/bootgraph.pl > +++ b/scripts/bootgraph.pl > @@ -44,7 +44,7 @@ my %end; > my %type; > my $done = 0; > my $maxtime = 0; > -my $firsttime = 100; > +my $firsttime = 99999; > my $count = 0; > my %pids; > my %pidctr; Adding Arjan to CC. Arjan, if you are OK with the patch, I can take it through my tree with your Ack. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/