From: Arnd Bergmann <arnd@arndb.de>
To: Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH v3] arch/tile: add hypervisor-based character driver for SPI flash ROM
Date: Fri, 10 Jun 2011 18:41:27 +0200
User-Agent: KMail/1.12.2 (Linux/2.6.37; KDE/4.3.2; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
        Eric Biederman <ebiederm@aristanetworks.com>,
        Chris Wright <chrisw@sous-sol.org>,
        Benjamin Thery <benjamin.thery@bull.net>,
        Phil Carmody <ext-phil.2.carmody@nokia.com>
References: <201105281516.p4SFGfHg024703@farm-0010.internal.tilera.com> <BANLkTim-d-8w1_idg4u302aB3MqTo7q4Sg@mail.gmail.com> <201106021510.p52FAlmb028120@farm-0023.internal.tilera.com>
In-Reply-To: <201106021510.p52FAlmb028120@farm-0023.internal.tilera.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201106101841.27771.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2393
Lines: 41

On Thursday 02 June 2011, Chris Metcalf wrote:
> The first version of this patch proposed an arch/tile/drivers/ directory,
> but the consensus was that this was probably a poor choice for a place to
> group Tilera-specific drivers, and that in any case grouping by platform
> was discouraged, and grouping by function was preferred.
> 
> This version of the patch addresses various issues raised in the
> community, primarily the absence of sysfs integration.  The sysfs
> integration now handles passing information on sector size, page size,
> and total partition size to userspace as well.  In addition, we now
> use a single "struct cdev" to manage all the partition minor devices,
> and dynamically discover the correct number of partitions from the
> hypervisor rather than using a module_param with a default value.
> 
> This driver has no particular "peer" drivers it can be grouped with.
> It is sort of like an MTD driver for SPI ROM, but it doesn't group well
> with the other MTD devices since it relies on hypervisor virtualization
> to handle many of the irritating aspects of flash ROM management: sector
> awareness, background read for sub-sector writes, bit examination to
> determine whether a sector erase needs to be issued, etc.  It is in fact
> more like an EEPROM driver, but the hypervisor virtualization does require
> a "flush" command if you wish to commit a sector write prior to writing
> to a different sector, and this is sufficiently different from generic
> I2C/SPI EEPROMs that as a result it doesn't group well with them either.
> 
> The simple character device is already in use by a range of Tilera
> SPI ROM management tools, as well as by customers.  In addition, using
> the simple character device actually simplifies the userspace tools,
> since they don't need to manage sector erase, background read, etc.
> This both simplifies the code (since we can uniformly manage plain files
> and the SPI ROM) as well as makes the user code portable to non-Linux
> platforms that don't offer the same MTD ioctls.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/