Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757911Ab1FJSP5 (ORCPT ); Fri, 10 Jun 2011 14:15:57 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:54846 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854Ab1FJSP4 convert rfc822-to-8bit (ORCPT ); Fri, 10 Jun 2011 14:15:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=IW2HYuZqGtlQpqzP69WGko4lggwpMukockIHV8HvKHF7+ZSv+8KJAXd0VurDa4CEK/ xW2gDkcRRfqh2HTRpIro5nVd1tEQVaz4qQNovDPHZeOs+vQyUV2koadY4ldtFA9fyq3b F7+OZSIdwJoQX6YsZw54LXL8rCdLLkcIIz9Do= MIME-Version: 1.0 In-Reply-To: References: <1307726331-28618-1-git-send-email-lars@metafoo.de> <4DF25AF5.6070909@metafoo.de> From: Mike Frysinger Date: Fri, 10 Jun 2011 14:15:34 -0400 Message-ID: Subject: Re: [Device-drivers-devel] [PATCH 1/3] ASoC: Add ADAU1701 codec driver To: Lars-Peter Clausen Cc: Mark Brown , Liam Girdwood , uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, device-drivers-devel@blackfin.uclinux.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1995 Lines: 41 On Fri, Jun 10, 2011 at 14:08, Mike Frysinger wrote: > On Fri, Jun 10, 2011 at 13:57, Lars-Peter Clausen wrote: >> On 06/10/2011 07:43 PM, Mike Frysinger wrote: >>> On Fri, Jun 10, 2011 at 13:18, Lars-Peter Clausen wrote: >>>> +MODULE_AUTHOR("Lars-Peter Clausen "); >>> >>> did you actually rewrite this thing from scratch ?  seems like you >>> should keep Cliff as the author in git/MODULE_AUTHOR, and then add >>> your name to the s-o-b list and this macro. >> >> Not from scratch, but I guess except for the register definitions and the >> copyright header not much of the original driver is left: >> sound/soc/codecs/adau1701.c |  662 ++++++++++++++++++++++++------------------- >>  1 files changed, 371 insertions(+), 291 deletions(-) > > based purely on LoC, Cliff wrote 467, so you took that and punted 291 > (62%) and then added 371.  that leaves the final file with 32% Cliff > and 68% you. > > however, some of that was register renaming and shuffling between the > adau1701.c and adau1701.h, and it's easier to start with a base and > clean up than from scratch. > > so i'm definitely not comfortable dropping Cliff's completely from the > file and the log (which means he needs to be readded and made sure to > be retained in all the other ADAU drivers going forward), and i'm not > entirely sold about changing of the Author field in the git commit. > > don't get me wrong ... i'm not a fanboi of Cliff or something, i just > think credit is due to him for his work. to be clear, i'm like 50/50 on the git author field. maybe someone else here has an opinion, or you feel strongly enough that your rewrite supersedes his seeding work. but please send a v2 with updated source/changelog with his name in it. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/