Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155Ab1FKVh3 (ORCPT ); Sat, 11 Jun 2011 17:37:29 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:57929 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146Ab1FKVhZ (ORCPT ); Sat, 11 Jun 2011 17:37:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=REFuJj7jL1dqKtuclY3WCfMlJF1e6sSsiJLa+Gp4y/KJFKPNS3PKvDnFod5/UAUNqI 0i5IHJN7NQC3WNDXFhQs+97bVTdvMD1tP+cGLVbx9WfEx6eO6+OYXmsEj8bhFleLm3jG rFsL5r2qmHvszkiOEzH2OhsyMt+1ObtxCU/9A= From: Connor Hansen To: marcel@holtmann.org Cc: padovan@profusion.mobi, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Connor Hansen Subject: [PATCH] :V2 drivers/bluetooth/bpa10x.c: missing kfrees Date: Sat, 11 Jun 2011 14:36:11 -0700 Message-Id: <1307828171-22010-1-git-send-email-cmdkhh@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 49 both bpa10x_submit_initr_urb() and bpa10x_submit_bulk_urb() malloc a char buffer(buf) for usb_fill_init_usb() but fail to free it after freeing the urb. Likewise, bpa10x_send_frame() allocates a usb_ctrlrequest(dr) for sending packets but does not free it after the usb_fill_control_urb() call. Signed-off-by: Connor Hansen --- drivers/bluetooth/bpa10x.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/bluetooth/bpa10x.c b/drivers/bluetooth/bpa10x.c index 751b338..0a2dd9e 100644 --- a/drivers/bluetooth/bpa10x.c +++ b/drivers/bluetooth/bpa10x.c @@ -254,6 +254,7 @@ static inline int bpa10x_submit_intr_urb(struct hci_dev *hdev) } usb_free_urb(urb); + kfree(buf); return err; } @@ -295,6 +296,7 @@ static inline int bpa10x_submit_bulk_urb(struct hci_dev *hdev) } usb_free_urb(urb); + kfree(buf); return err; } @@ -393,6 +395,7 @@ static int bpa10x_send_frame(struct sk_buff *skb) skb->data, skb->len, bpa10x_tx_complete, skb); hdev->stat.cmd_tx++; + kfree(dr); break; case HCI_ACLDATA_PKT: -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/