Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616Ab1FLW3u (ORCPT ); Sun, 12 Jun 2011 18:29:50 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:42622 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754223Ab1FLW3s (ORCPT ); Sun, 12 Jun 2011 18:29:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=B1gvGEWv7aqdcM7GoQ35HJwWJAlV6nMAz8O6GxoeGFPVYfrO3GH2RJ/3qSYFXWfegN H/CgbvhNf+seGW8G+PDFtIMl2jz4QHcbkJ9XNLH7bSEsIAkpLDYpH8U0faCSDpcnSdKh lSdWkRa1Sm2Fkf54Nh7XpehPqSddZh2NcgIcQ= Message-ID: <4DF53DCC.1060604@gmail.com> Date: Sun, 12 Jun 2011 15:29:32 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Len Brown Subject: Re: [PATCH]drivers:base:power:trace.c Add "UTC" Coordinated Universal Time to the printk. References: <1307599301-2524-1-git-send-email-justinmattock@gmail.com> <201106122035.26600.rjw@sisk.pl> <4DF514BC.9030808@gmail.com> <201106122227.32992.rjw@sisk.pl> In-Reply-To: <201106122227.32992.rjw@sisk.pl> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2136 Lines: 54 On 06/12/2011 01:27 PM, Rafael J. Wysocki wrote: > On Sunday, June 12, 2011, Justin P. Mattock wrote: >> On 06/12/2011 11:35 AM, Rafael J. Wysocki wrote: >>> On Sunday, June 12, 2011, Justin P. Mattock wrote: >>>> On 06/12/2011 05:12 AM, Rafael J. Wysocki wrote: >>>>> Hi, >>>>> >>>>> On Thursday, June 09, 2011, Justin P. Mattock wrote: >>>>>> From: "Justin P. Mattock" >>>>>> >>>>>> sounds stupid, but taking a glance at the time, and seeing the wrong time, or what seemed >>>>>> wrong in dmesg, caused me to go into total check the time clock panic mode.. So the patch below adds: >>>>>> "UTC" Coordinated Universal Time abreviation to the printk so people like me dont flip out over the time! >>>>>> >>>>>> before: >>>>>> [ 0.114915] Time: 1:47:03 Date: 06/09/11 >>>>>> >>>>>> after: >>>>>> [ 0.114728] Time: 5:46:02 UTC Date: 06/09/11 >>>>>> >>>>>> Signed-off-by: Justin P. Mattock >>>>> >>>>> I suspect the goal is to mark messages printed by the PM trace code so that >>>>> they can be easily distinguished from messages from other sources to avoid >>>>> confusion. Why do you think it's a good idea to use the "UTC" string for >>>>> this purpose? The time printed in those messages need not be UTC. >>>>> >>>>> It would be better to simply print "RTC time: ..., date: ..." IMO. >>>>> >>>>> Thanks, >>>>> Rafael >>>>> >>>> >>>> well.. if thats better, then thats better.. over here(people that dont >>>> know what RTC time is) would not get so confused with a simple UTC or >>>> PDT or whatever the time zone is but if RTC is bettr, then its better. >>> >>> My point is we don't know this time is always UTC, so we rather shouldn't >>> label it as UTC unconditionally, should we? >>> >>> Rafael >>> >> >> sounds good to me!! > > I'm not sure what you mean? > with what you are saying "RTC" if anything.. rather than "UTC" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/