Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774Ab1FMBEP (ORCPT ); Sun, 12 Jun 2011 21:04:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:59049 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754286Ab1FMBEO convert rfc822-to-8bit (ORCPT ); Sun, 12 Jun 2011 21:04:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,356,1304319600"; d="scan'208";a="15435796" From: Andi Kleen To: Chris Mason Cc: "Linus Torvalds" , "linux-btrfs" , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] Btrfs updates References: <1307879298-sup-3080@shiny> Date: Sun, 12 Jun 2011 18:02:54 -0700 In-Reply-To: <1307879298-sup-3080@shiny> (Chris Mason's message of "Sun, 12 Jun 2011 07:57:34 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 36 Chris Mason writes: > Hi everyone, > > The for-linus branch of the btrfs unstable tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git for-linus > > Has our current queue of fixes. Josef's is the biggest pile, mostly in > the allocator. Josef and I both managed to merge his patch to avoid > mapping the extent buffer if skip_locking was set, git merge is just a > little too easy sometimes (I double checked the resulting code). The new in 3.0 btrfs warnings on every build are still there: fs/btrfs/sysfs.c:76: warning: ‘btrfs_root_attrs’ defined but not used fs/btrfs/sysfs.c:97: warning: ‘btrfs_super_attrs’ defined but not used fs/btrfs/sysfs.c:153: warning: ‘btrfs_super_release’ defined but not used fs/btrfs/sysfs.c:160: warning: ‘btrfs_root_release’ defined but not used These are not even used inside any ifdef. It's unclear to me: were these supposed to be used or removed? Probably better to remove since they seem to be untested, unless it was a merge error? -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/