Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753862Ab1FMHve (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2011 03:51:34 -0400
Received: from mail-wy0-f174.google.com ([74.125.82.174]:48849 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753459Ab1FMHvb convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2011 03:51:31 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=ibH7KiOhHq9dw9sHNGallX5sC2pceZRyTB+3UvZwp2xWTSoMiYIGLnFUoXSJPpaKdt
         KElzZe/rpwc+9EPVmV4j8yCYRb5rBbkKtZzf2mD045e3gbyltRUYjFNDIiE6RqWRI1y0
         g0lSScKbYeVf8wFA+pTN7a2TTTFJVaty8UfBo=
MIME-Version: 1.0
In-Reply-To: <4DF57C29.4070601@mit.edu>
References: <1307875953.1859.6.camel@Tux>
	<4DF57C29.4070601@mit.edu>
Date: Mon, 13 Jun 2011 09:51:30 +0200
Message-ID: <BANLkTinkxK4th8+KLt5YBYf42009Ced9tA@mail.gmail.com>
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
From: Maarten Lankhorst <m.b.lankhorst@gmail.com>
To: Andy Lutomirski <luto@mit.edu>
Cc: "wanlong.gao" <wanlong.gao@gmail.com>, linux-kernel@vger.kernel.org,
        linux-fbdev@vger.kernel.org, Peter Jones <pjones@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1327
Lines: 41

Hi Andy,

2011/6/13 Andy Lutomirski <luto@mit.edu>:
> On 06/12/2011 06:52 AM, wanlong.gao wrote:
>>
>> <snip>
>>
>> Hi Maarten:
>> It registered efifb_device but try to unregistered efifb_driver,
>> so I think you should fix it like this?
>>
>> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
>> ---
>>  drivers/video/efifb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
>> index 69c49df..784139a 100644
>> --- a/drivers/video/efifb.c
>> +++ b/drivers/video/efifb.c
>> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
>>         */
>>        ret = platform_driver_probe(&efifb_driver, efifb_probe);
>>        if (ret) {
>> -               platform_device_unregister(&efifb_driver);
>> +               platform_device_unregister(&efifb_device);
>>                return ret;
>>        }
>>
>
> Acked-by: Andy Lutomirski <luto@mit.edu>
>
> That's my bug.  Sorry.  I'm not sure why it compiled, though.
It compiled, but threw a warning. :)

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/