Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751093Ab1FMJTs (ORCPT ); Mon, 13 Jun 2011 05:19:48 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:59490 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826Ab1FMJTq (ORCPT ); Mon, 13 Jun 2011 05:19:46 -0400 Subject: Re: [PATCH] unicore32, exec: remove redundant set_fs(USER_DS) From: Guan Xuetao Reply-To: gxt@mprc.pku.edu.cn To: Mathias Krause Cc: Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, arnd@arndb.de In-Reply-To: <1307711463-17752-1-git-send-email-minipli@googlemail.com> References: <1307711463-17752-1-git-send-email-minipli@googlemail.com> Content-Type: text/plain; charset="UTF-8" Organization: MPRC, PKU Date: Mon, 13 Jun 2011 17:19:40 +0800 Message-ID: <1307956780.1878.13.camel@epip-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 40 On Fri, 2011-06-10 at 15:11 +0200, Mathias Krause wrote: > The address limit is already set in flush_old_exec() so this > set_fs(USER_DS) is redundant. > > Signed-off-by: Mathias Krause > --- > arch/unicore32/include/asm/processor.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/unicore32/include/asm/processor.h b/arch/unicore32/include/asm/processor.h > index e11cb07..f0d780a 100644 > --- a/arch/unicore32/include/asm/processor.h > +++ b/arch/unicore32/include/asm/processor.h > @@ -53,7 +53,6 @@ struct thread_struct { > #define start_thread(regs, pc, sp) \ > ({ \ > unsigned long *stack = (unsigned long *)sp; \ > - set_fs(USER_DS); \ > memset(regs->uregs, 0, sizeof(regs->uregs)); \ > regs->UCreg_asr = USER_MODE; \ > regs->UCreg_pc = pc & ~1; /* pc */ \ Hi Mathias, I searched for the code in flush_old_exec(), but I can't find the code you mentioned. Could you make it more clear? And, if all fs codes (not only elf and aout) have the similar implementations, perhaps all arch-specific codes should be manipulated in the meanwhile. Also Cc: Arnd Bergmann Thanks & Regards. Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/