Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494Ab1FMJmJ (ORCPT ); Mon, 13 Jun 2011 05:42:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52058 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751244Ab1FMJmG (ORCPT ); Mon, 13 Jun 2011 05:42:06 -0400 Date: Mon, 13 Jun 2011 11:42:03 +0200 From: Michal Hocko To: Johannes Weiner Cc: KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Ying Han , Andrew Morton , Rik van Riel , Minchan Kim , KOSAKI Motohiro , Mel Gorman , Greg Thelen , Michel Lespinasse , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 7/8] vmscan: memcg-aware unevictable page rescue scanner Message-ID: <20110613094203.GC10563@tiehlicka.suse.cz> References: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> <1306909519-7286-8-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306909519-7286-8-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 59 On Wed 01-06-11 08:25:18, Johannes Weiner wrote: > Once the per-memcg lru lists are exclusive, the unevictable page > rescue scanner can no longer work on the global zone lru lists. > > This converts it to go through all memcgs and scan their respective > unevictable lists instead. > > Signed-off-by: Johannes Weiner Just a minor naming thing. Other than that looks good to me. Reviewed-by: Michal Hocko > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h [...] > +struct page *mem_cgroup_lru_to_page(struct zone *zone, struct mem_cgroup *mem, > + enum lru_list lru) > +{ > + struct mem_cgroup_per_zone *mz; > + struct page_cgroup *pc; > + > + mz = mem_cgroup_zoneinfo(mem, zone_to_nid(zone), zone_idx(zone)); > + pc = list_entry(mz->lists[lru].prev, struct page_cgroup, lru); > + return lookup_cgroup_page(pc); > +} > + [...] > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3233,6 +3233,14 @@ void scan_mapping_unevictable_pages(struct address_space *mapping) > > } > > +static struct page *lru_tailpage(struct zone *zone, struct mem_cgroup *mem, > + enum lru_list lru) > +{ > + if (mem) > + return mem_cgroup_lru_to_page(zone, mem, lru); > + return lru_to_page(&zone->lru[lru].list); > +} Wouldn't it better to have those names consistent? mem_cgroup_lru_tailpage vs lru_tailpage? [...] -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/