Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521Ab1FMJrJ (ORCPT ); Mon, 13 Jun 2011 05:47:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52148 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925Ab1FMJrG (ORCPT ); Mon, 13 Jun 2011 05:47:06 -0400 Date: Mon, 13 Jun 2011 11:47:04 +0200 From: Michal Hocko To: Johannes Weiner Cc: KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Ying Han , Andrew Morton , Rik van Riel , Minchan Kim , KOSAKI Motohiro , Mel Gorman , Greg Thelen , Michel Lespinasse , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 0/8] mm: memcg naturalization -rc2 Message-ID: <20110613094704.GD10563@tiehlicka.suse.cz> References: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2239 Lines: 55 On Wed 01-06-11 08:25:11, Johannes Weiner wrote: > Hi, > > this is the second version of the memcg naturalization series. The > notable changes since the first submission are: > > o the hierarchy walk is now intermittent and will abort and > remember the last scanned child after sc->nr_to_reclaim pages > have been reclaimed during the walk in one zone (Rik) > > o the global lru lists are never scanned when memcg is enabled > after #2 'memcg-aware global reclaim', which makes this patch > self-sufficient and complete without requiring the per-memcg lru > lists to be exclusive (Michal) > > o renamed sc->memcg and sc->current_memcg to sc->target_mem_cgroup > and sc->mem_cgroup and fixed their documentation, I hope this is > better understandable now (Rik) > > o the reclaim statistic counters have been renamed. there is no > more distinction between 'pgfree' and 'pgsteal', it is now > 'pgreclaim' in both cases; 'kswapd' has been replaced by > 'background' > > o fixed a nasty crash in the hierarchical soft limit check that > happened during global reclaim in memcgs that are hierarchical > but have no hierarchical parents themselves > > o properly implemented the memcg-aware unevictable page rescue > scanner, there were several blatant bugs in there > > o documentation on new public interfaces > > Thanks for your input on the first version. I have finally got through the whole series, sorry that it took so long, and I have to say that I like it. There is just one issue I can see that was already discussed by you and Ying regarding further soft reclaim enhancement. I think it will be much better if that one comes as a separate patch though. So thank you for this work and I am looking forward for a new version. I will try to give it some testing as well. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/