Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898Ab1FMKf2 (ORCPT ); Mon, 13 Jun 2011 06:35:28 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:41997 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092Ab1FMKf1 (ORCPT ); Mon, 13 Jun 2011 06:35:27 -0400 Date: Mon, 13 Jun 2011 12:35:05 +0200 From: Johannes Weiner To: Michal Hocko Cc: KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Ying Han , Andrew Morton , Rik van Riel , Minchan Kim , KOSAKI Motohiro , Mel Gorman , Greg Thelen , Michel Lespinasse , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 0/8] mm: memcg naturalization -rc2 Message-ID: <20110613103505.GB12143@cmpxchg.org> References: <1306909519-7286-1-git-send-email-hannes@cmpxchg.org> <20110613094704.GD10563@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110613094704.GD10563@tiehlicka.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2595 Lines: 57 On Mon, Jun 13, 2011 at 11:47:04AM +0200, Michal Hocko wrote: > On Wed 01-06-11 08:25:11, Johannes Weiner wrote: > > Hi, > > > > this is the second version of the memcg naturalization series. The > > notable changes since the first submission are: > > > > o the hierarchy walk is now intermittent and will abort and > > remember the last scanned child after sc->nr_to_reclaim pages > > have been reclaimed during the walk in one zone (Rik) > > > > o the global lru lists are never scanned when memcg is enabled > > after #2 'memcg-aware global reclaim', which makes this patch > > self-sufficient and complete without requiring the per-memcg lru > > lists to be exclusive (Michal) > > > > o renamed sc->memcg and sc->current_memcg to sc->target_mem_cgroup > > and sc->mem_cgroup and fixed their documentation, I hope this is > > better understandable now (Rik) > > > > o the reclaim statistic counters have been renamed. there is no > > more distinction between 'pgfree' and 'pgsteal', it is now > > 'pgreclaim' in both cases; 'kswapd' has been replaced by > > 'background' > > > > o fixed a nasty crash in the hierarchical soft limit check that > > happened during global reclaim in memcgs that are hierarchical > > but have no hierarchical parents themselves > > > > o properly implemented the memcg-aware unevictable page rescue > > scanner, there were several blatant bugs in there > > > > o documentation on new public interfaces > > > > Thanks for your input on the first version. > > I have finally got through the whole series, sorry that it took so long, > and I have to say that I like it. There is just one issue I can see that > was already discussed by you and Ying regarding further soft reclaim > enhancement. I think it will be much better if that one comes as a > separate patch though. People have been arguing in both directions. I share the sentiment that that the soft limit rework is a separate thing, though, and will make this series purely about the exclusive per-memcg lru lists. Once this is done, the soft limit stuff should follow immediately. > So thank you for this work and I am looking forward for a new version. > I will try to give it some testing as well. Thanks for your input and testing! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/