Date: Mon, 13 Jun 2011 13:42:04 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        yrl.pp-manager.tt@hitachi.com, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@gmail.com>
Subject: Re: [PATCH 14/15] stack_trace: Add weak save_stack_trace_regs()
Message-ID: <20110613114204.GA10960@elte.hu>
References: <20110609172744.333794089@goodmis.org>
 <20110609172914.028158916@goodmis.org>
 <20110613101955.GE30962@elte.hu>
 <4DF5EBD4.7070207@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DF5EBD4.7070207@hitachi.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 808
Lines: 27


* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> (2011/06/13 19:19), Ingo Molnar wrote:
> > 
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> >> +save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
> >> +{
> >> +	WARN_ONCE(1,
> >> +		  KERN_INFO "save_stack_trace_regs() not implemented yet.\n");
> > 
> >  - pointless linebreak
> >  - we don't add KERN_ tags to WARN*() invocations
> 
> Hm, I just copied save_stack_trace_tsk(). OK, I'll remove it.

Please remove it from save_stack_trace_tsk() as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/