Subject: Re: [PATCH 15/15] tracing/kprobes: Fix kprobe-tracer to support
 stack trace
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        yrl.pp-manager.tt@hitachi.com,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@gmail.com>
In-Reply-To: <20110613115051.GE10960@elte.hu>
References: <20110609172744.333794089@goodmis.org>
	 <20110609172914.290174627@goodmis.org> <20110613102118.GF30962@elte.hu>
	 <1307965484.9218.59.camel@gandalf.stny.rr.com>
	 <20110613115051.GE10960@elte.hu>
Content-Type: text/plain; charset="ISO-8859-15"
Date: Mon, 13 Jun 2011 08:14:47 -0400
Message-ID: <1307967287.9218.64.camel@gandalf.stny.rr.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 955
Lines: 28

On Mon, 2011-06-13 at 13:50 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > > > +	__ftrace_trace_stack(global_trace.buffer, flags, 3, preempt_count(),
> > > > +			     NULL);
> > > 
> > > pointless linebreak.
> > 
> > Again, probably to do with the 80 char limit.
> 
> Well, the point of the 80 char limit warning these days is to force a 
> cleanup of the code. Breaking the line mindlessly *uglifies* the code 
> so it's pointless to do it.
> 
> In terms of terminal readability line length up to 90-100 cols is 
> acceptable for code that is otherwise not ugly.

I totally agree. I've just had arguments with others that are more 80
character nazi than I am. ;)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/