Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754071Ab1FMTDq (ORCPT ); Mon, 13 Jun 2011 15:03:46 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:57824 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752744Ab1FMTDp (ORCPT ); Mon, 13 Jun 2011 15:03:45 -0400 Date: Mon, 13 Jun 2011 15:03:44 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tanya Brokhman cc: balbi@ti.com, , , , , "'open list'" , "'open list:FREESCALE USB PER...'" , "'open list:OMAP USB SUPPORT'" Subject: RE: [PATCH] usb:gadget: use min_t() macro instead of min() In-Reply-To: <03db01cc29f4$d472bcb0$7d583610$@org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 22 On Mon, 13 Jun 2011, Tanya Brokhman wrote: > > > > The change I suggested involved replacing two typecasts with a single > > min_t. All (or almost all) the places this patch touches currently > > contain only one typecast, so the motivation for changing them is a lot > > weaker. > > > You're right. So what's the final call on this one? Do you think it can be > merged or you prefer not change anything? I personally think the code looks > nicer using min_t instead of min with casting but that's just my opinion and > of course there are arguments against this patch. I don't care either way. It's up to you and Felipe. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/