Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754887Ab1FMVmS (ORCPT ); Mon, 13 Jun 2011 17:42:18 -0400 Received: from mail.perches.com ([173.55.12.10]:2860 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907Ab1FMVmQ (ORCPT ); Mon, 13 Jun 2011 17:42:16 -0400 Subject: Re: [PATCH 1/3] usbip: only dump valid port status From: Joe Perches To: =?ISO-8859-1?Q?N=E9meth_M=E1rton?= Cc: Greg Kroah-Hartman , Matt Mooney , Max Vozeler , Sarah Sharp , usbip-devel@lists.sourceforge.net, devel@driverdev.osuosl.org, LKML In-Reply-To: <4DF68151.4080109@freemail.hu> References: <4DF68151.4080109@freemail.hu> Content-Type: text/plain; charset="UTF-8" Date: Mon, 13 Jun 2011 14:42:14 -0700 Message-ID: <1308001334.26699.18.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 31 On Mon, 2011-06-13 at 23:29 +0200, Németh Márton wrote: > From: Márton Németh > > The wIndex parameter of vhci_hub_control() is always zero when the > request type is GetHubDescriptor, > --- > diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c > @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, > > if (usbip_dbg_flag_vhci_rh) { > pr_debug("port %d\n", rhport); > - dump_port_status(prev_port_status[rhport]); > - dump_port_status(dum->port_status[rhport]); > + /* Only dump valid port status */ > + if (0 <= rhport) { > + dump_port_status(prev_port_status[rhport]); > + dump_port_status(dum->port_status[rhport]); > + } > } > usbip_dbg_vhci_rh(" bye\n"); > Linux relatively rarely uses constant before variable in a comparison. ie: please use "if (rhport > 0)" instead -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/