Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683Ab1FNBZV (ORCPT ); Mon, 13 Jun 2011 21:25:21 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:55565 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686Ab1FNBZT (ORCPT ); Mon, 13 Jun 2011 21:25:19 -0400 X-AuditID: b753bd60-a50caba000003bac-3a-4df6b87cad13 X-AuditID: b753bd60-a50caba000003bac-3a-4df6b87cad13 Message-ID: <4DF6B878.3060903@hitachi.com> Date: Tue, 14 Jun 2011 10:25:12 +0900 From: Masami Hiramatsu Organization: Systems Development Lab., Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Steven Rostedt Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Andrew Morton , Frederic Weisbecker , yrl.pp-manager.tt@hitachi.com, Ingo Molnar , Peter Zijlstra , Namhyung Kim Subject: Re: [PATCH 15/15] tracing/kprobes: Fix kprobe-tracer to support stack trace References: <20110609172744.333794089@goodmis.org> <20110609172914.290174627@goodmis.org> <20110613102118.GF30962@elte.hu> <1307965484.9218.59.camel@gandalf.stny.rr.com> <20110613115051.GE10960@elte.hu> <1307967287.9218.64.camel@gandalf.stny.rr.com> In-Reply-To: <1307967287.9218.64.camel@gandalf.stny.rr.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 34 (2011/06/13 21:14), Steven Rostedt wrote: > On Mon, 2011-06-13 at 13:50 +0200, Ingo Molnar wrote: >> * Steven Rostedt wrote: >> >>>>> + __ftrace_trace_stack(global_trace.buffer, flags, 3, preempt_count(), >>>>> + NULL); >>>> >>>> pointless linebreak. >>> >>> Again, probably to do with the 80 char limit. >> >> Well, the point of the 80 char limit warning these days is to force a >> cleanup of the code. Breaking the line mindlessly *uglifies* the code >> so it's pointless to do it. >> >> In terms of terminal readability line length up to 90-100 cols is >> acceptable for code that is otherwise not ugly. > > I totally agree. I've just had arguments with others that are more 80 > character nazi than I am. ;) I see, nowadays most of laptops has a wide screen (16:9) :P -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/