Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144Ab1FNEzc (ORCPT ); Tue, 14 Jun 2011 00:55:32 -0400 Received: from relay01.digicable.hu ([92.249.128.189]:41167 "EHLO relay01.digicable.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155Ab1FNEz3 (ORCPT ); Tue, 14 Jun 2011 00:55:29 -0400 Message-ID: <4DF6E9B8.7060908@freemail.hu> Date: Tue, 14 Jun 2011 06:55:20 +0200 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Joe Perches CC: devel@driverdev.osuosl.org, usbip-devel@lists.sourceforge.net, Matt Mooney , Greg Kroah-Hartman , LKML , Sarah Sharp Subject: Re: [PATCH 1/3] usbip: only dump valid port status References: <4DF68151.4080109@freemail.hu> <1308001334.26699.18.camel@Joe-Laptop> <4DF6857B.3050206@freemail.hu> <1308003828.26699.45.camel@Joe-Laptop> In-Reply-To: <1308003828.26699.45.camel@Joe-Laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Original: 94.21.98.7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1773 Lines: 44 Joe Perches wrote: > On Mon, 2011-06-13 at 23:47 +0200, Németh Márton wrote: >> From: Márton Németh >> >> The wIndex parameter of vhci_hub_control() is always zero when the >> request type is GetHubDescriptor, see drivers/usb/core/hub.c::get_hub_descriptor() >> and Universal Serial Bus Specification revision 2.0 (April 27, 2000) Section >> 11.24.2.5 "Get Hub Descriptor". This means the variable rhport will not contain >> any useful index. Only use valid rhport values. >> >> Signed-off-by: Márton Németh >> --- >> drivers/staging/usbip/vhci_hcd.c | 7 +++++-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c >> index 359b464..512a97f 100644 >> --- a/drivers/staging/usbip/vhci_hcd.c >> +++ b/drivers/staging/usbip/vhci_hcd.c >> @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, >> >> if (usbip_dbg_flag_vhci_rh) { >> pr_debug("port %d\n", rhport); >> - dump_port_status(prev_port_status[rhport]); >> - dump_port_status(dum->port_status[rhport]); >> + /* Only dump valid port status */ >> + if (rhport >= 0) { >> + dump_port_status(prev_port_status[rhport]); >> + dump_port_status(dum->port_status[rhport]); >> + } > > Umm, you mean to use "rhport > 0" yes? No, it is really (rhport >= 0). The wIndex parameter is zero, the rhport is wIndex - 1. So rhport zero is valid, rhport -1 is not valid. Regards, Márton Németh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/