Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754851Ab1FNHdy (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jun 2011 03:33:54 -0400
Received: from linux-sh.org ([111.68.239.195]:34726 "EHLO linux-sh.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752837Ab1FNHdx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jun 2011 03:33:53 -0400
Date: Tue, 14 Jun 2011 16:33:42 +0900
From: Paul Mundt <lethal@linux-sh.org>
To: Andy Lutomirski <luto@MIT.EDU>
Cc: "wanlong.gao" <wanlong.gao@gmail.com>, linux-kernel@vger.kernel.org,
        linux-fbdev@vger.kernel.org,
        Maarten Lankhorst <m.b.lankhorst@gmail.com>,
        Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH] efifb: Fix call to wrong unregister function
Message-ID: <20110614073341.GG17891@linux-sh.org>
References: <1307875953.1859.6.camel@Tux> <4DF57C29.4070601@mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4DF57C29.4070601@mit.edu>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1170
Lines: 35

On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote:
> On 06/12/2011 06:52 AM, wanlong.gao wrote:
> ><snip>
> >
> >Hi Maarten:
> >It registered efifb_device but try to unregistered efifb_driver,
> >so I think you should fix it like this?
> >
> >Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com>
> >---
> >  drivers/video/efifb.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> >index 69c49df..784139a 100644
> >--- a/drivers/video/efifb.c
> >+++ b/drivers/video/efifb.c
> >@@ -541,7 +541,7 @@ static int __init efifb_init(void)
> >  	 */
> >  	ret = platform_driver_probe(&efifb_driver, efifb_probe);
> >  	if (ret) {
> >-		platform_device_unregister(&efifb_driver);
> >+		platform_device_unregister(&efifb_device);
> >  		return ret;
> >  	}
> >
> 
> Acked-by: Andy Lutomirski <luto@mit.edu>
> 
Updated version applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/