Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755321Ab1FNIaC (ORCPT ); Tue, 14 Jun 2011 04:30:02 -0400 Received: from adelie.canonical.com ([91.189.90.139]:59785 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754676Ab1FNIaA (ORCPT ); Tue, 14 Jun 2011 04:30:00 -0400 Message-ID: <4DF71C01.6080504@canonical.com> Date: Tue, 14 Jun 2011 16:29:53 +0800 From: Ike Panhc User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org CC: Matthew Garrett , Dmitry Torohov Subject: Re: [PATCH] ideapad: let Fn+F5 also trigger KEY_BLUETOOTH References: <1308040109-12038-1-git-send-email-ike.pan@canonical.com> In-Reply-To: <1308040109-12038-1-git-send-email-ike.pan@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 32 On 06/14/2011 04:28 PM, Ike Panhc wrote: > The design for ideapad Fn-F5 key is not only for wifi but for all > radio device including wifi, bluetooth and wwan. Idealy it shall > acts like this: > > wifi on wifi off wifi on wifi off > bt on -----> bt on -----> bt off -----> bt off > > This patch will switch wifi mode every key-push and switch > bluetooth mode every two key-push. This maybe is disputed. The problem is that now Fn+F5 only turns on/off wifi and leave bluetooth alone. According to the design this hotkey shall change the status of all radio devices, including wifi, bluetooth and wwan. On machine with wifi and bluetooth, it will turn on/off wifi and bluetooth in order. On machine with wifi, it will switch wifi mode on every event. I think it is better to solve this in driver not in user space application because on some other platforms, the KEY_WLAN and KEY_BLUETOOTH are separate. I do not have a clear idea how to deal with wwan interface such as it shall be exclusive or inclusive with wifi. Please reply for any opinion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/