Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755357Ab1FNIqF (ORCPT ); Tue, 14 Jun 2011 04:46:05 -0400 Received: from na3sys009aog117.obsmtp.com ([74.125.149.242]:49194 "EHLO na3sys009aog117.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755310Ab1FNIqB convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2011 04:46:01 -0400 From: Bing Zhao To: Julian Calaby , Joe Perches CC: "netdev@vger.kernel.org" , "Luis R. Rodriguez" , Jouni Malinen , Vasanthakumar Thiagarajan , Senthil Balasubramanian , "John W. Linville" , Christian Lamparter , Stanislaw Gruszka , Wey-Yi Guy , Intel Linux Wireless , "linux-wireless@vger.kernel.org" , "ath9k-devel@lists.ath9k.org" , "linux-kernel@vger.kernel.org" Date: Tue, 14 Jun 2011 01:45:07 -0700 Subject: RE: [PATCH net-next 1/2] wireless: Remove casts of void * Thread-Topic: [PATCH net-next 1/2] wireless: Remove casts of void * Thread-Index: AcwqVZT9Bem6jWnuQ6GEItM/CchD6gAGE47b Message-ID: <477F20668A386D41ADCC57781B1F704307FF7C464F@SC-VEXCH1.marvell.com> References: <337c22b774ff7f007b90b266b25c9a33ff555c48.1308024069.git.joe@perches.com> <1308029532.26699.68.camel@Joe-Laptop>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 24 >> diff --git a/drivers/net/wireless/mwifiex/11n.c b/drivers/net/wireless/mwifiex/11n.c >> @@ -191,7 +191,7 @@ int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp, void *data_buf) >> struct host_cmd_ds_11n_cfg *htcfg = &resp->params.htcfg; >> >> if (data_buf) { >> - tx_cfg = (struct mwifiex_ds_11n_tx_cfg *) data_buf; >> + tx_cfg = data_buf; >> >> I think pretty useless. tx_cfg is a struct mwifiex_ds_11n_tx_cfg *. > > True, but IMHO, this documents, particularly in a random snippet like > this, what's going on. Arguably though, a better fix would be to move > the cast to the place where this function is called. Hi Julian, Thanks for your comment. We will work on this. Regards, Bing-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/