Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888Ab1FNOAc (ORCPT ); Tue, 14 Jun 2011 10:00:32 -0400 Received: from mail.perches.com ([173.55.12.10]:2983 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369Ab1FNOAb (ORCPT ); Tue, 14 Jun 2011 10:00:31 -0400 Subject: Re: [PATCH net-next 2/2] drivers/net: Remove casts of void * From: Joe Perches To: Geert Uytterhoeven Cc: netdev@vger.kernel.org, Arnaldo Carvalho de Melo , Jay Cliburn , Chris Snook , Jie Yang , Sathya Perla , Subbu Seetharaman , Ajit Khaparde , Rasesh Mody , Debashis Dutt , Sjur Braendeland , Divy Le Ray , Breno Leitao , Amit Kumar Salecha , Ron Mercer , linux-driver@qlogic.com, Anirban Chakraborty , Jon Mason , Solarflare linux maintainers , Steve Hodgson , Ben Hutchings , Daniele Venzano , David Dillow , linux-kernel@vger.kernel.org In-Reply-To: References: <486a21b708a9dce0c1c0059a21a2f9b66dac9e3c.1308024069.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 14 Jun 2011 07:00:28 -0700 Message-ID: <1308060028.18987.6.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 50 On Tue, 2011-06-14 at 11:21 +0200, Geert Uytterhoeven wrote: > On Tue, Jun 14, 2011 at 06:02, Joe Perches wrote: > > Unnecessary casts of void * clutter the code. > > --- a/drivers/net/a2065.c > > +++ b/drivers/net/a2065.c > > @@ -426,7 +426,7 @@ static irqreturn_t lance_interrupt (int irq, void *dev_id) > > volatile struct lance_regs *ll; > > int csr0; > > > > - dev = (struct net_device *) dev_id; > > + dev = dev_id; > > I think it would look better if you merge this line with the line that > defines "dev". I think so too, but I also think it should look like below and that's something better done in a separate pass, don't you think? diff --git a/drivers/net/a2065.c b/drivers/net/a2065.c index deaa8bc..25ea98a 100644 --- a/drivers/net/a2065.c +++ b/drivers/net/a2065.c @@ -421,16 +421,11 @@ static int lance_tx (struct net_device *dev) static irqreturn_t lance_interrupt (int irq, void *dev_id) { - struct net_device *dev; - struct lance_private *lp; - volatile struct lance_regs *ll; + struct net_device *dev = dev_id; + struct lance_private *lp = netdev_priv(dev); + volatile struct lance_regs *ll = lp->ll; int csr0; - dev = (struct net_device *) dev_id; - - lp = netdev_priv(dev); - ll = lp->ll; - ll->rap = LE_CSR0; /* LANCE Controller Status */ csr0 = ll->rdp; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/